How to add quotes in mysql query?

Question

1.00/5 (1 vote)

See more:

I have this

      if ($_POST["manufacturers"]) {
        $where = addWhere($where, "make IN (".htmlspecialchars(implode(",", $_POST["manufacturers"])).")");
      }
      $sql = "SELECT * FROM vehicles";
      if ($where) {
        $sql .= " WHERE $where";
      }
echo $sql;

mysql query i get is:

SELECT * FROM vehicles WHERE make IN (Tesla,Ford);

This query doesn't work because there's no quotation marks. Example ('Tesla','Ford').
For example if column value was a number, for example id, then it would work. So, how can i add quotation marks between values in parentheses?

What I have tried:

Tried changing column name and values in parentheses. If values inside of the parentheses are numbers than query works.

Posted 24-Feb-18 10:12am

User 13662680

Updated 24-Feb-18 10:52am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-02-24T10:52:00

Reading documentation is the first thing to do, there is 2 solutions in this page:
PHP: Strings - Manual[^]

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]

User 13662680 · Answer 2 · 2018-02-24T10:52:00

Solution 2

$where = addWhere($where, "type IN (".htmlspecialchars(implode(",", array_map(function($string) {
return '"' . $string . '"';
  }, $data))).")");

Posted 24-Feb-18 10:52am