OnClientClick and OnClick on asp:button

Question

0.00/5 (No votes)

See more:

Hey everyone,

I have a button in which I am using both OnClientClick and OnClick.

The onClientClick works well, but when onClientClick condition is not met, Server side click event is not fired.

C#

<asp:Button ID="btnDelete" runat="server" Text="Delete" Style="float: left; margin-right: 10px; color: black; font-weight: bold; margin-left: 40px" Height="26px" Width="67px" OnClientClick = "javascript:selectedItems(); return false;" OnClick = "btnDelete_Click" CausesValidation="false" />

C#

function selectedItems()
         {
          var MasterTable = $find("<%=RadGrid1.ClientID%>").get_masterTableView();
          var selectedItemsCount = MasterTable.get_selectedItems().length;
          if (selectedItemsCount == 0) {
              alert("Select at least one item!");
              return false;
                       }
                     }

Posted 1-Nov-10 20:48pm

AmitChoudhary10

Updated 1-Nov-10 22:28pm

Dalek Dave

v2

Add a Solution

Comments

Hiren solanki 2-Nov-10 3:08am

try by return true inside client event at end.

Dalek Dave 2-Nov-10 4:27am

Edited for Grammar and Readability.

3 solutions

Solution 3

XML

Hi,
I have a ASP button in my web application as:-

<asp DropDownList ID="dropDown1" runat="server">
    <asp:ListItem></asp:ListItem>
    <asp:ListItem value="reject">Reject</asp:ListItem>
    <asp:ListItem value="accept">Accept</asp:ListItem>
</asp DropDownList>
<asp:TextBox ID="TextBox1" runat="server"></<asp:TextBox>

<asp:Buton ID="button7" runat="server" CommandName="update" CssClass="button"
onclientclick="return checkDecision();" onclick="button7_Click" Text="Submit"
UseSubmitBehavior="False">

<script type="text/javascript">

function checkDecision(){
     if(document.getElementByID("dropDown1").value == "reject" && document.getElementById("TextBox1").value == ""){
     alert("Please fill the textbox");
     return false;
     }
     else{
        return true;
     }
</script>

On clicking the submit button the checkDecision() function is getting called properly. When it returns true that is dropDown is selected with reject and textbox is not empty then "button7_click" function on server side is not getting called..

Can any1 please help me with this ?? Thank You in advance....

Regards,
~Sorabh

Posted 2-Feb-12 11:26am

sorabh11586

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Baji Jabbar · Accepted Answer · 2010-11-01T21:13:00

Solution 1

You are returning 'false' always . ie is the issue.
Change the calling of javascript function as

OnClientClick="javascript: return selectedItems();"<br />

Hope this will help you :)

Posted 1-Nov-10 21:13pm

Baji Jabbar

Comments

Dalek Dave 2-Nov-10 4:27am

Good Call.

Arindam Tewary · Accepted Answer · 2010-11-01T21:22:00

Hi,

your problme is in this line

OnClientClick="javascript:selectedItems();return false;"

if "return false" is execute then it would never submit and OnClick(which is sever side would never executed).

"return false" statement should be conditional.

change the code like this:

OnClientClick="javascript:selectedItems();"

and in the defination of selectedItems() javascript function

if (selectedItemsCount == 0) 
{                       
    alert("Select at least one item!");
    return false;
}
else
{
    // this path ensures that when user selects at least 1 item then it 
    // proceeds to server side code OnClick to be executed.
    return true;
}

Hope that helps,

Thanks
Arindam D Tewary,