Get user name from one form to another

Question

1.00/5 (1 vote)

See more:

Get user name from one form to another

Users groups

access rights

I have error in this line

korisnickaGrupa = Int32.Parse(myCommand3.ExecuteScalar().ToString());

Sql query are OK

Some help?

What I have tried:

private void prijava()
        if (korisnikId > 0)
            {
                command = "SELECT osobe_korisnici.lozinka FROM osobe_korisnici where osobe_korisnici.id = " + korisnikId;
                SqlCommand myCommand2 = new SqlCommand(command, myConnection);
                String lozinka = myCommand2.ExecuteScalar().ToString();
                if (lozinka == lozinkaTextBox.Text)
                {
                    command = "SELECT korisnik_grupa.redni_broj FROM korisnik_grupa where korisnik_grupa.broj_grupe = \"" + korisnikId + "\"";
                    //MessageBox.Show(command);
                    SqlCommand myCommand3 = new SqlCommand(command, myConnection);
                    korisnickaGrupa = Int32.Parse(myCommand3.ExecuteScalar().ToString());
                   
                    if (korisnickaGrupa == 1)
                        {
                        findsUserName();
                        DialogResult = DialogResult.OK;
                    }
                    else
                    {
                        errorLabel.Text = "You dont have acces for this app";
                    }
                }
                else
                {
                    errorLabel.Text = "Wrong password";
                }
            }
            else
            {
                errorLabel.Text = "Wrong user name";
            }


        }

public void findsUserName()
        {
            SqlConnection myConnection = new SqlConnection(cs);
            String command = "SELECT ime_prezime FROM osobe_korisnici  where id = \"" + korisnikId + "\"";
            //MessageBox.Show(command);
            SqlCommand myCommand = new SqlCommand(command, myConnection);


            myCommand.Connection.Open();
            this.korisnickoIme = myCommand.ExecuteScalar().ToString();
        }

Posted 22-May-18 23:06pm

Stylus STYLUS

Updated 23-May-18 0:49am

Add a Solution

Comments

Stylus STYLUS 23-May-18 5:07am

private static int korisnikId;
private static int korisnickaGrupa;
private string korisnickoIme;

I forgot this...I added on start code line

Ziee-M 23-May-18 5:34am

What is the exception you get ?
It seems your returned id (before parse) is in wrong format, probably a special caracter in the start and/Or the end. Just remove them with a Trim() or anyother way.

Stylus STYLUS 23-May-18 5:41am

Exception is number from command

Stylus STYLUS 23-May-18 5:42am

I wrong I need help. Thank you

Richard Deeming 25-May-18 8:17am

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Fix that, and you'll almost certainly fix your error too.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2018-05-23T00:50:00

Solution 1

Quote:
Int32.Parse(myCommand3.ExecuteScalar().ToString());

This statement is a potential source of many exceptions, you have to handle them properly.
You stated your query is OK, but neverthless such code fails. Use the debugger to locate the problem (e.g. invalid textual representation of a Int32).

Posted 23-May-18 0:50am

CPallini

Comments

Stylus STYLUS 24-May-18 1:32am

korisnikId = Convert.ToInt32(myCommand.ExecuteScalar());

This line is error