Random password generator problem

Question

1.00/5 (2 votes)

See more:

Hello. I am trying to code a random password generator but I assume a problem.

Problem is:
VB

str2 = Conversions.ToString(random.Next(0, pool.Length)) str = (str & Conversions.ToString(pool(Conversions.ToInteger(str2))))

What I have tried:

VB

Dim num As Integer = 0
        Me.TextBox1.Text = ""
        Dim str As String = ""
        Dim random As New Random
        Dim str2 As String = ""
        Do While (num < 3)
            str2 = Conversions.ToString(random.Next(0, pool.Length))
            str = (str & Conversions.ToString(pool(Conversions.ToInteger(str2))))
            num += 1
        Loop
        Me.TextBox1.Text = ("1618ML00" & str & "8")

Posted 24-Nov-18 12:21pm

Member 14065947

Updated 24-Nov-18 13:59pm

Add a Solution

Comments

MadMyche 24-Nov-18 21:04pm

What is the problem? Is there an Exception being thrown?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2018-11-24T13:59:00

You might want to actually describe the problem. Just posting a line of code as the problem doesn't really say anything about what you think the problem is.

Also, that line of code itself IS a problem because it's so badly written, along with the entire method it's in.

It looks like you're trying to generate a random password using random indexes into an array of characters, correct?

A method should do exactly ONE thing. In this case, generate a string made up of random characters. It should NOT do anything with a textbox or preprend/append any characters other than the ones it's picking to the string.

'  Assume "pool" is an array of characters accessible by this method.
Public Function GeneratePasswordString(length As Integer) As String
    If length < 0 Then
        Throw New ArgumentException
    End If

    Dim RNG As New Random
    Dim buffer As New StringBuilder
    Dim index As Integer

    For count As Integer = 1 to length
        index = RNG.Next(0, pool.length)
        buffer.Append(pool(index))
    Next

    Return buffer.ToString
End Function