I am building a program to calculate sum and divisors of a number entered but I am getting some bugs

Question

1.00/5 (1 vote)

See more:

So i am building a calculation program the program should ask the user a number with at most 7 digits and then calculate the sum of the numbers For example: number = 1259955 , sum= 36 like this then the program should list all divisors of the sum above Example:

sum=8 , divisors = 1,2,3,4,6,9,12,18,36

Like this

My code i wrote is executing the sum part but not the divisor part

Also when the line Console.Writeline("Sum of the digits of" + number + "is"+ sum) is executing The output is : Sum of the digits 0 is 36 Why is it saying 0

What I have tried:

C#

int number;
        int sum = 0;
        Console.WriteLine("Enter a number with at most 7 digits: ");
        number = Convert.ToInt32(Console.ReadLine());

        while (number != 0)
        {
            sum += number % 10;
            number /= 10;
        }

        Console.WriteLine("Sum of the digits of " + number + " is " + sum);



        for (int i = 1; i <= number; i++)
        {
            if (number % i ==0)
            {

                Console.WriteLine("The divisors of" + sum + " are " + i.ToString());
            }


        }

        Console.ReadLine();
    }
}

Posted 9-Dec-18 4:53am

Member 14075859

Updated 9-Dec-18 8:03am

RickZeeland

v2

Add a Solution

Comments

Richard MacCutchan 9-Dec-18 11:21am

Your initial loop reduces number to zero. Please try reading your code through if it does not do what you expect.

2 solutions

Solution 2

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

Debugging C# Code in Visual Studio - YouTube[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Posted 9-Dec-18 8:04am

Patrice T

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RASHID ALI786 · Accepted Answer · 2018-12-09T05:22:00

Hello,
Hope you are doing well.

there is a bit problem in your algorithm you are using a 'number' as an integer to get data from a user and using the same variable inside the while loop makes it value 0,

that's why it says

Sum of the digits 0 is 36

and this is the reason the for loop is not executing because of the number=0.

Solution is simple

take another variable save the original value in it and that's it.

int number,val;
            int sum = 0;
            Console.WriteLine("Enter a number with at most 7 digits: ");
            number = Convert.ToInt32(Console.ReadLine());
            val = number;
            while (number != 0)
            {
                sum += number % 10;
                number /= 10;
            }

            Console.WriteLine("Sum of the digits of " + val + " is " + sum);



            for (int i = 1; i <= val; i++)
            {
                if (val % i == 0)
                {

                    Console.WriteLine("The divisors of " + sum + " are " + i.ToString());
                }


            }

            Console.ReadLine();