Problem in code that must not repeat the same number in PHP

Question

0.00/5 (No votes)

See more:

Hello guys
I've wrote this function that returns a time(number )that must not exist in the same day in the database which means that the same time must not be repeated but when i execute it the time(number) is repeated
can you help me sort this one out?

note: the table is empty and it will be filled when the entire code is executed i have just posted the function that must not repeat the time.

function checkTime($className,$day,$conn){
      
    global $numberLimet,$Daily,$UserLimt,$exist;

    $sqlHoure = "SELECT * from schedule WHERE classname='".$className."'";
    $hourQuery = mysqli_query($conn,$sqlHoure);
    $h = array();
    

    while ($hour = mysqli_fetch_assoc($hourQuery)){
 
        
        $h[$hour['hour']] = $hour['day1'];

       // array_search();
    }

    $number = rand(1,7);

    if(array_search($day,$h) && array_key_exists($number,$h)){


        return 'error';


    }else{

        
     if($hour['hour'] != $number && $hour['day1']  != $day){

        $numberLimet++;
        if($numberLimet == $Daily){
            $UserLimt = 1;
            $FristAdd = false;

            echo("UserLimt" . $UserLimt);

            return 'errorLimit';
        }else{
            return $number;

        }

     }else{
     }
      
     // 
        

    }

    return $h;


          
}

What I have tried:

i tried to change the code many times but the same result

Posted 14-Dec-18 7:48am

RonoRed

Updated 14-Dec-18 8:37am

v11

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2018-12-14T08:13:00

PHP

$sqlHoure = "SELECT * from schedule WHERE classname='".$className."'";

Not necessary a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]
How can I explain SQL injection without technical jargon? - Information Security Stack Exchange[^]