How do I redirect to page based on value in db column

Question

0.00/5 (No votes)

See more:

i have a page where two different departments will login called 1.Waste and 2.Environment. i want the page to redirect to a specific page if the users department is Waste and also a different page if the users department is Environment. in my register table i have the columns name, surname , email , password and department

if department = Waste
Redirect to page 1 else
if department = Environment
Redirect to page 2

i get an error "An exception of type 'System.IndexOutOfRangeException' occurred in System.Data.dll but was not handled in user code"

Not sure how to implement this into the following code:

What I have tried:
Code

What I have tried:

SqlConnection con = new SqlConnection(strConnString);
SqlCommand cmd = new SqlCommand("select * from [dbo].[PB_Register] where pb_Email= @Login_Email and pb_Password=@Login_Password", con);
cmd.Parameters.AddWithValue("@Login_Email",Login_Email.Text);
cmd.Parameters.AddWithValue("@Login_Password", Login_Password.Text);  

Session["Username"] = Login_Email.Text;

con.Open();
SqlDataReader rd = cmd.ExecuteReader();

if (rd.HasRows) {
   
    rd.Read();
       if (rd["Departmet"].ToString() == "EPIP")
                Response.Redirect("UPLOAD.aspx");
            else
                if (rd["Departmet"].ToString() == "Waste")
                Response.Redirect("EMAIL_FILE.aspx");  
            


} else {

    ClientScript.RegisterStartupScript(GetType(), "alert", "alert('Username or Password incorrect');", true);

}  
}

Posted 3-Apr-19 4:51am

Member 14183767

Updated 3-Apr-19 5:20am

Add a Solution

Comments

ZurdoDev 3-Apr-19 10:57am

Step 1 is to understand what your code does. Then, doing what you want to do is very easy.

Department is spelled wrong which is why it can't find it in rd.

Member 14183767 3-Apr-19 11:02am

its still giving me the same error , this is my login page, i would like for the code to check what department is in PB_Register for each user and redirect to appropriate page

ZurdoDev 3-Apr-19 11:04am

Again, you need to first learn what the code does.

Calling rd = cmd.ExecuteReader() will execute the sql statement that you have. If you want to access a column in the result then you can do it by using rd["columnName"].ToString().

Member 14183767 3-Apr-19 11:08am

i understand now what its doing thanks for that! but issue is that even when ive used ur solution i still get an error which is confusing me, plz help i am still learning

ZurdoDev 3-Apr-19 11:09am

Then you have typed something wrong. What is the name of the column in the PB_Register table that you want to check?

Member 14183767 3-Apr-19 11:13am

Department

ZurdoDev 3-Apr-19 11:16am

You mispelled it in the code above. So, fix that and if you get an error then tell us which line of code caused the error and what the error is.

Member 14183767 3-Apr-19 11:17am

i fixed that it throws an error on this code : if(rd["Departmet"].ToString() == "EPIP")

ZurdoDev 3-Apr-19 11:18am

and what is the error?

Member 14183767 3-Apr-19 11:19am

"An exception of type 'System.IndexOutOfRangeException' occurred in System.Data.dll but was not handled in user code" Additional info 'Department'

ZurdoDev 3-Apr-19 11:21am

IndexOutOfRangeException, that means the column you are referencing by index (rd["Department"]) does not exist.

Open Sql Server Management Studio and run
select * from [dbo].[PB_Register]

Member 14183767 3-Apr-19 11:31am

it exists i just checked

ZurdoDev 3-Apr-19 11:34am

Then your code is pointing to a different database or you still have it typed wrong. Errors don't lie.

Something is off, and I can't see what you are doing so you'll have to find it.

Richard Deeming 4-Apr-19 11:10am

You're storing passwords in plain text. Don't do that!

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

Richard Deeming 4-Apr-19 11:11am

And why are you re-inventing the wheel? ASP.NET has several perfectly good authentication systems built-in - for example, ASP.NET Identity[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

MadMyche · Accepted Answer · 2019-04-03T05:21:00

The sloppy way would be to grab this within a WHILE loop in some variation of this

C#

if (rd.HasRows) {
  while (rs.Read()) {
    string RedirectURL = rd["ColumnName"];
  }
}
Response.Redirect(RedirectURL);

I would probably redo this to be something more like this; you only need one value from one row so ExecuteScalar would be much more efficient. And what happens if they are in neither group? I threw in an Exception for that.
You may need to fix some typos as I do not have an IDE checking my typing

C#

SqlConnection con = new SqlConnection(strConnString);

// Just grab the column you need
SqlCommand cmd = new SqlCommand("SELECT Departmet FROM [dbo].[PB_Register] WHERE pb_Email= @Login_Email AND pb_Password=@Login_Password", con);

cmd.Parameters.AddWithValue("@Login_Email",Login_Email.Text);
cmd.Parameters.AddWithValue("@Login_Password", Login_Password.Text);  

Session["Username"] = Login_Email.Text;

con.Open();

// SqlDataReader rd = cmd.ExecuteReader();
var DepartmentName = cmd.ExecuteScalar();

if (DepartmentName != null) {
  switch(DepartmentName.ToSting()) {
    case "EPIP" : Response.Redirect("UPLOAD.aspx"); break
    case "Waste" : Response.Redirect("EMAIL_FILE.aspx"); break
    default: throw new ArgumentOutOfRangeException("Department", "The department does not have an assigned path"); break
  } 
} else {
  ClientScript.RegisterStartupScript(GetType(), "alert", "alert('Username or Password incorrect');", true);

}