Invalidoperationexception: there is already an open datareader associated with this command which must be closed first. With ASP.NET identity

Question

0.00/5 (No votes)

See more:

I'm trying to return data from database:

public List<DataModel> GET()
    {
        foreach (var users in db.Users) {
            var user = db.Users.Select(x => new DataModel()
            {
                Email = users.Email,
                UserName = users.UserName,
                FirstName = users.FirstName,
                LastName = users.LastName,
                Age = users.Age,
                Phone = users.Phone,
                Department = users.Department
            });
            return user.ToList();

        }

Here is db class:

public class ApplicationDbContext : IdentityDbContext<ApplicationUser, CustomRole,
int, CustomUserLogin, CustomUserRole, CustomUserClaim>
{
    public ApplicationDbContext()
        : base("DefaultConnection")
    {
    }

    public static ApplicationDbContext Create()
    {
        return new ApplicationDbContext();
    }
}

Here is the error:

InvalidOperationException: There is already an open DataReader associated with this Command which must be closed first.

Could you please tell what's wrong with this code?

What I have tried:

I have four record in database and the following code return four record but with first record data !!

public List<DataModel> GET()
           {


                   var user = db.Users.Select(x => new DataModel()
                   {
                       Email = db.Users.FirstOrDefault().Email,
                       UserName = db.Users.FirstOrDefault().UserName,
                       FirstName = db.Users.FirstOrDefault().FirstName,
                       LastName = db.Users.FirstOrDefault().LastName,
                       Age = db.Users.FirstOrDefault().Age,
                       Phone = db.Users.FirstOrDefault().Phone,
                       Department = db.Users.FirstOrDefault().Department
                   });
                   return user.ToList();

           }

Posted 8-Apr-19 7:13am

Member 12919448

Updated 8-Apr-19 7:19am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2019-04-08T07:20:00

It's probably because this line

foreach (var users in db.Users)

opens a connection and this line

var user = db.Users.Select(

sets up a second connection which is activated when you use .ToList on the following line.

You don't actually need the two loops, this is untested but try something like

public List<DataModel> GET()
    {
            var user = db.Users.Select(x => new DataModel()
            {
                Email = x.Email,
                UserName = x.UserName,
                FirstName = x.FirstName,
                LastName = x.LastName,
                Age = x.Age,
                Phone = x.Phone,
                Department = x.Department
            });

            return user.ToList();

        }