Problem to call a javascript function

Question

4.50/5 (2 votes)

See more:

Hello to all!

I am using geocode API3 and the code is working fine, but the problem is when I call codeAddress function through dropdown change event. It increases the marker in the map. I am creating a marker in codeAddress that's increased on every call of the function codeAddress. I want a single marker displayed at every call of my codeAddress function.

Here is my code:

JavaScript

function codeAddress() {
    var address = document.getElementById("address").value;
    geocoder.geocode( { 'address': address}, function(results, status) {
      if (status == google.maps.GeocoderStatus.OK) {
        map.setCenter(results[0].geometry.location);
        marker = new google.maps.Marker({
            map: map,
            draggable: true,
            position: results[0].geometry.location
        });
        google.maps.event.addListener(marker, 'drag', function(event) {
        document.getElementById('<%= txtLatitude.ClientID %>').value = marker.getPosition().lat();
        document.getElementById('<%= txtLongitude.ClientID %>').value = marker.getPosition().lng();
        document.getElementById('<%= HFLat.ClientID %>').value = marker.getPosition().lat();
        document.getElementById('<%= HFLng.ClientID %>').value = marker.getPosition().lng();
        });
      } else {
        alert("Geocode was not successful for the following reason: " + status);
      }
    });

HTML

<select name="address" id="address" onchange="codeAddress();" >
    <option value="India">India</option>
    <option value="Australia">Australia</option>
    <option value="Pakistan">Pakistan</option></select>

Can anyone help me please?

Posted 27-Feb-11 22:55pm

balongi

Updated 27-Feb-11 23:11pm

Manfred Rudolf Bihy

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Manfred Rudolf Bihy · Answer 1 · 2011-02-27T23:17:00

If you want to keep using the same marker you must change your code as you're always creating a new google.maps.marker in your function. You may try it like this:

JavaScript

var myPermanentMarker = new google.maps.Marker({
                              map: map,
                              draggable: true
                        });
google.maps.event.addListener(myPermanentMarker , 'drag', function(event){
    document.getElementById('<%= txtLatitude.ClientID %>').value = myPermanentMarker.getPosition().lat();
    document.getElementById('<%= txtLongitude.ClientID %>').value = myPermanentMarker.getPosition().lng();
    document.getElementById('<%= HFLat.ClientID %>').value = myPermanentMarker.getPosition().lat();
    document.getElementById('<%= HFLng.ClientID %>').value = myPermanentMarker.getPosition().lng();
});

JavaScript

function codeAddress() {
    var address = document.getElementById("address").value;
    geocoder.geocode( { 'address': address}, function(results, status) {
        if (status == google.maps.GeocoderStatus.OK)
        {
            myPermanentMarker.position = results[0].geometry.location;
            map.setCenter(results[0].geometry.location);
        }
        else
        {
            alert("Geocode was not successful for the following reason: " + status);
        }
    });