I am looking to see if this code is right.

Question

0.00/5 (No votes)

See more:

I am trying to create a directory
It must first check to see if directory exist. If not create one.

public void createNewFolder()
{
  DirectoryInfo di = new DirectoryInfo("..\\DATA\\" + BUSINESSNAME.Text);

  //Check to see if company directory exist
  if (!di.Exists)
  {
    try
    {
     di = Directory.CreateDirectory(this.Server.MapPath("..\\DATA\\" + BUSINESSNAME.Text));
    }
    catch
    {
     this.Page.Response.Write("Director was not created.");
    }
  }
   else
   {
    this.Page.Response.Write("Director exist already. Please go to edit/update Page.");
   }
}

Posted 8-Apr-11 8:55am

postonoh

Add a Solution

3 solutions

Solution 1

Why not debug it and see if it works correctly? At it's current state it'll just check one relative directory which should be under predefined DATA directory.

Another note. In my opinion it would be more elegant (and likely to be re-usable) to pass the directory name as a parameter than to hard code it into the method.

Posted 8-Apr-11 9:08am

Wendelius

Comments

Sergey Alexandrovich Kryukov 8-Apr-11 15:29pm

Absolutely, my 5. More to it, not following your second advice would not be acceptable.
--SA

Wendelius 8-Apr-11 15:37pm

Thanks :)

Solution 3

When you check to see if your directory exists, you are not checking the same path as the path you are using to create the new directory.

You check to see if "..\\DATA\\" + BUSINESSNAME.Text exists, but then you create this.Server.MapPath("..\\DATA\\" + BUSINESSNAME.Text).

The DirectoryInfo object should probably use the same this.Server.MapPath("..\\DATA\\" + BUSINESSNAME.Text) path.

Posted 8-Apr-11 9:14am

Kythen

Comments

Sergey Alexandrovich Kryukov 8-Apr-11 15:31pm

What would you expect if OP does hard-coding? That is a real problem... Mika is right.
--SA

Kythen 8-Apr-11 15:35pm

You are absolutely correct. I was just trying to point out the plain path vs. Server.MapPath discrepancy which hadn't been pointed out yet at the time I wrote this answer. :)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-04-08T09:13:00

I would suggest that it needs some revision.

At present, you are checking one folder, then (potentially) creating one with a different path. Instead, try building a new string, and using that exclusivly:

string path = Server.MapPath(@"..\DATA\" + BUSINESSNAME.Text);

Secondly, why not use the same DirectoryInfo as you checked with anyway?

DirectoryInfo di = new DirectoryInfo(path);
if (!di.Exists)
    {
    try
        {
        di.Create();
        }
    catch (Exception ex)
        {
        ...
        }
    }
else
    {
    ...
    }