problem in validating email id in MFC

Question

0.00/5 (No votes)

See more:

hi,
im validating email id for that im using this code

void CEMailDlg::OnValidate()
 { 
   // TODO: Add your control notification handler code here 
   CString m_sFrom;
   for(int a=0;a &lt; m_sFrom.GetLength(); a++)
   { 
   if(m_sFrom.GetAt(a) == '@')
   { 
    AfxMessageBox("valid"); 
   }
    else 
   {
   AfxMessageBox("invalid");
   } 
  } 
}

now the email id is not validating the problem is in this statement
for(int a=0;a < m_sFrom.GetLength(); a++) i think there is problem in "m_sFrom.GetLength();"... i dono what problem it is,, pls help me

Posted 10-May-11 19:37pm

degorio

Updated 10-May-11 20:46pm

Toniyo Jackson

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2011-05-10T19:40:00

Solution 1

You need to assign something to m_sFrom.
You are defining it (CString m_sFrom) but it has not been instantiated - thus throwing an error when you try to check the length.

Posted 10-May-11 19:40pm

Abhinav S

Joan M · Answer 2 · 2011-05-10T20:42:00

1. OnValidate should receive as parameter the string variable to be checked OR
2. The string variable should be assigned via a third function OR
3. The string variable should be a global variable out of the function...

Anyway, in your code the variable has no value as it has not been initialized... Therefore it is not possible to iterate it...

What Abhinav S tells you is 100% correct you should avoid checking the string if the minimum requirements are not fulfilled...

HTH...