problem in html text editor

Question

4.00/5 (2 votes)

See more:

hello friends i m having text editor in that i want to store data in data base. in that i found error when i type 'asdfasdf'
i know the logic when we replace these

to some sign and store it in database but i dont know how to done dis

freetextbox1.text is <big>text editor</big>

my code is

try
        {
            con.Open();
            SqlCommand cmd = new SqlCommand("update content set pagetitle='"+TxtPagetitle.Text+"',description='"+FreeTextBox1.Text+"' where pagename='"+ddlQuees.Text+"' ", con);
            cmd.ExecuteNonQuery();
            
            Up.Text = "Updated Successfullly";
            con.Close();
            bind();
        }
        catch
        {

            Up.Text = "not done";
        }

Posted 26-May-11 2:33am

beginner in C#.net

Updated 31-May-11 2:50am

v3

Add a Solution

2 solutions

Solution 1

You should never, ever use direct unvalidated user input in a SQL script. Search for SQL Injection to understand why.

You should be using stored procedures or at the least parametrized queries.

Posted 26-May-11 2:43am

Not Active

Comments

Wonde Tadesse 26-May-11 20:28pm

5+

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-05-26T02:48:00

Don't concatenate strings. Not only does it cause problems like the one you are having, but it leaves you open to an SQL Injection attack, which could accidentally or deliberately destroy your database.

Instead, use parametrized queries:

try
    {
    con.Open();
    SqlCommand cmd = new SqlCommand("UPDATE content SET pagetitle=@PT, description=@DS WHERE pagename=@PN", con);
    cmd.Parameters.AddWithValue("@PT", TxtPagetitle.Text);
    cmd.Parameters.AddWithValue("@DS", FreeTextBox1.Text);
    cmd.Parameters.AddWithValue("@PN", ddlQuees.Text);
    cmd.ExecuteNonQuery();

    Up.Text = "Updated Successfullly";
    bind();
    }
catch
    {
    Up.Text = "not done";
    }
finally
    {
    con.Close();
    }

That should fix your problem!