std::vector<myproppage*> pPages;
and
pPages[i] = new MyPropPage();
are not the same thing.
Put
CString title0(_T("title0"));
above and out of your for loop. And you failed to initialize numberOfPages from else where. And its not just CString anymore.
pPages[i]->m_psp.pszTitle = title0;