how to make process for,while,repeat not like crash if while run repeat very long?

Question

3.67/5 (3 votes)

See more:

Using VS2010 c# for windows phone, how do I make process iteration (method for or while or repeat) not like crash and showing progress finish if this method run iteration very long.

private void button4_Click(object sender, RoutedEventArgs e)
        {
            progressBar1.Maximum = 10000;
            for (int i = 1; i <= 10000; i++)
            {
                textBox1.Text = Convert.ToString(i);
                progressBar1.Value = i;
            }
        }

While the process is running, I want progress bar show the progress step by step.
thanks

Posted 22-Jun-11 2:03am

bagus bujangga

Updated 22-Jun-11 21:57pm

Dalek Dave

v2

Add a Solution

Comments

Dalek Dave 23-Jun-11 4:01am

Edited for Clarity, but still unclear.

6 solutions

Solution 4

For any processing which takes 'a long time', you should not run it on the UI thread. 'A long time' has various definitions but anything over a second and you are probably into it. I'm not sure if the mobile framework supports the Task Parallel library that's part of desktop .Net 4, but I'm pretty sure it does support BackgroundWorkerThreads and normal threading, thread pool etc from .Net 2. You should start your long running process as a Task or BackgroundWorkerThread, and the long running code should fire status update events which can be hooked by the main application to update a UI control (don't forget to use Invoke or Begin/EndInvoke to do that part as status events will be raised on the background thread).

Posted 22-Jun-11 5:57am

BobJanova

Solution 6

Just simply add a windows timer, when the timer tick, add one to the process bar value.

Besides, you need start a thread to handle the task. When the task ends, invoke the UI thread to remove the process bar and let user know the task is done.

From Athena Solution, Singapore (Please No advertisement)

Posted 22-Jun-11 17:11pm

Member 795700

Updated 24-Jun-11 5:14am

v2

Comments

Richard MacCutchan 23-Jun-11 7:31am

Adding a timer is not the answer here; the update of the progress bar needs to be synchronised with whatever background task is being measured. See the suggestions of SAKryukov.

Solution 3

Hello,

What about this ?

C#

private int counter;
System.Timers.Timer timer = new System.Timers.Timer();

public MYForm()
{
     InitializeComponent();
     timer.Elapsed += new System.Timers.ElapsedEventHandler(timer_Elapsed);
}

void timer_Elapsed(object sender, System.Timers.ElapsedEventArgs e)
{
    counter++;
}


public void MyMethod()
{

    progressBar1.Maximum = 10000;
    timer.Interval = 500;
    timer.Start();
    counter = 0;
    for (int i = 1; i <= 100000000; i++)
    {
        if (counter == 10)
            break;
        textBox1.Text = Convert.ToString(i);
        progressBar1.Value = i;
    }
}

Posted 22-Jun-11 3:09am

Shahin Khorshidnia

Comments

Dalek Dave 23-Jun-11 4:02am

Fair enough.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-06-22T08:54:00

The code makes no sense, but probably you need to process some real data and notify the progress in UI later on.

You need an extra thread, nothing else (don't repeat common fallacy, don't use timers)!

Create a separate thread. This is a code sample for a very robust way:
How to pass ref parameter to the thread[^].

You cannot call anything related to UI from non-UI thread. Instead, you need to use the method Invoke or BeginInvoke of System.Windows.Threading.Dispatcher (for both Forms or WPF) or System.Windows.Forms.Control (Forms only).

You will find detailed explanation of how it works and code samples in my past answers:
Control.Invoke() vs. Control.BeginInvoke()[^],
Problem with Treeview Scanner And MD5[^].

See also more references on threading:
How to get a keydown event to operate on a different thread in vb.net[^],
Control events not firing after enable disable + multithreading[^].

—SA

Richard MacCutchan · Accepted Answer · 2011-06-22T02:07:00

Solution 1

What are you trying to measure here? Your loop will not take long to reach 10000 and so it's unlikely that your user will see the interim displays. You need to synchronise your code with whatever background activity you are trying to monitor.

Posted 22-Jun-11 2:07am

Richard MacCutchan

Comments

Sergey Alexandrovich Kryukov 22-Jun-11 14:50pm

Good point. Something which makes no sense; but maybe this is just experimenting.
--SA

Sergey Alexandrovich Kryukov 22-Jun-11 14:54pm

Please see also my solution.
--SA

Pete O'Hanlon 23-Jun-11 4:57am

Balanced out the rating imbalance. It looks correct now.

fjdiewornncalwe · Accepted Answer · 2011-06-22T02:52:00

Solution 2

For starters, you should never set progressBar1.Value = i with out first ensuring that i is not greater than your maximum value.
i.e. prograssBar1.Value = Math.Min( progressBar1.Maximum, i ); or something of that nature. Then you also need to take into account Richard's answer as well.

Posted 22-Jun-11 2:52am

fjdiewornncalwe

Comments

Sergey Alexandrovich Kryukov 22-Jun-11 14:50pm

Good point, my 5.
--SA

Sergey Alexandrovich Kryukov 22-Jun-11 14:54pm

how to make process for,while,repeat not like crash if while run repeat very long?

6 solutions

Solution 5

Solution 1

Solution 2

Solution 4

Solution 6

Solution 3

Add your solution here

Preview 0

Existing Members

...or Join us