having no result in report

Question

0.00/5 (No votes)

See more:

hi,
i use this code to show the results of searching into crystalreportviewer.
it filters data between two date and two id .
when i execute it, it doesnt show any result.
what's wrong in this code?????

private void btnSearch_Click(object sender, EventArgs e)
       {
 
            SqlDataAdapter adapt = new SqlDataAdapter();
            adapt.SelectCommand = new SqlCommand();
            adapt.SelectCommand.Connection = cnn;
            adapt.SelectCommand.CommandType = CommandType.Text;
            adapt.SelectCommand.CommandText = "SELECT * FROM  View_Selling WHERE (khdate >='" + txtFromDate.Text.Trim() + "' AND khdate <  '" + txtToDate.Text.Trim() + "') AND (id >='" + txtFromCode.Text.Trim() + "' AND id < '" + txtToCode.Text.Trim() + "')    ";
            DataSet dset = new DataSet();
            cnn.Open();
            adapt.Fill(dset, "View_Selling");
            cnn.Close();
            CrystalReport1 objRPT = new CrystalReport1();
            objRPT.SetDataSource(dset);
            crystalReportViewer1.ReportSource = objRPT;

 
       }

help me
thanks alot

[edit]Code block added - OriginalGriff[/edit]

Posted 19-Jul-11 22:37pm

setareh_sky

Updated 19-Jul-11 22:41pm

OriginalGriff

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Abhinav S · Answer 1 · 2011-07-19T22:40:00

Solution 1

You are actually doing a compare on the id.
In that case, you will need to probably use numeric types rather than string types.

Remove the quotes in the query <='" + txtFromCode.Text.Trim() + "' AND should probably be <=" + txtFromCode.Text.Trim() + " AND.

Posted 19-Jul-11 22:40pm

Abhinav S

OriginalGriff · Answer 2 · 2011-07-19T22:48:00

To add to what Abhinav says, don't do it that way at all. Concatenating strings is a very bad idea - it can lead to SQL Injection attacks, were a user can accidentally of deliberately destroy your database. Use parametrised queries instead:

adapt.SelectCommand = new SqlCommand();
adapt.SelectCommand.Connection = cnn;
adapt.SelectCommand.CommandType = CommandType.Text;
adapt.SelectCommand.CommandText = "SELECT * FROM  View_Selling WHERE (khdate >=@FRDATE AND khdate < @TODATE) AND (id >=@FRID AND id < @TOID)";
adapt.SelectCommand.Parameters.AddWithValue("@FRDATE", DateTime.Parse(txtFromDate.Text.Trim()));
adapt.SelectCommand.Parameters.AddWithValue("@TODATE", DateTime.Parse(txtToDate.Text.Trim()));
...

This will probably get rid of your problem anyway, since the user is unlikely to be entering the dates in the correct (i.e. "yyyy-MM-dd") format for SQL server anyway.