not getting the data properly from database

Question

0.00/5 (No votes)

See more:

Hi,
I'm trying to get the data from the database.

For that i build one stored procedure as

SQL

ALTER Procedure [dbo].[Select_Students](@Sno int = null)
As
Begin
If @Sno Is Null
Select Sno,Sname,Class,Fees From Stud 
Else
Select Sname,Class,Fees From Stud Where Sno=@Sno
End

And the code under get button as

C#

private void button1_Click(object sender, EventArgs e)
        {
            cmd.Parameters.Clear();
            ds = new DataSet();
            da = new SqlDataAdapter();
            cmd.CommandText = "Select_Students";
            da = new SqlDataAdapter(cmd);
            da.Fill(ds, "Stu");
            string value_of_sno = textBox1.Text;
            cmd.Parameters.Add("@sno", value_of_sno);
            
              if (ds.Tables[0].Rows.Count > 0)
            {
                textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
                textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
                textBox4.Text = ds.Tables[0].Rows[0][3].ToString();
            }
            else
                MessageBox.Show("Record Not Existed");
        }

But always i'm getting the first record values only.
I think textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
textBox4.Text = ds.Tables[0].Rows[0][3].ToString();
due to this code only i'm getting the first record values.
can one help me to get the record values depending on the value entered by me in the first textbox.

Posted 17-Aug-11 0:53am

usha nelavalli

Updated 17-Aug-11 0:56am

Herman<T>.Instance

v2

Add a Solution

Comments

Herman<T>.Instance 17-Aug-11 6:58am

when @sno is null you will get a full list. Which value do you wnat to show then?
and your cmd.Parameters.Add() line should be set before you start with da = new SqlDataAdapter(cmd);

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Prerak Patel · Answer 1 · 2011-08-17T01:00:00

Solution 1

You have messed up your code. Adding parameter after Fill serves nothing.
Try this

C#

cmd.Parameters.Clear();
cmd.CommandText = "Select_Students";
string value_of_sno = textBox1.Text;
cmd.Parameters.Add("@sno", value_of_sno);
ds = new DataSet();
da = new SqlDataAdapter(cmd);
da.Fill(ds, "Stu");

Posted 17-Aug-11 1:00am

Prerak Patel

Updated 17-Aug-11 1:01am

v2

Herman<T>.Instance · Answer 2 · 2011-08-17T01:02:00

change

C#

if (ds.Tables[0].Rows.Count > 0)
            {
                textBox2.Text = ds.Tables[0].Rows[0][1].ToString();
                textBox3.Text = ds.Tables[0].Rows[0][2].ToString();
                textBox4.Text = ds.Tables[0].Rows[0][3].ToString();
            }

to:

C#

if (ds.Tables[0].Rows.Count > 0)
{
    foreach (DataRow row in ds.Tables[0].Rows)
    {
        if (row["sno"].ToString() == textbox1.Text)
        {
            textBox2.Text = row[1].ToString();
            textBox3.Text = row[2].ToString();
            textBox4.Text = row[3].ToString();
            break; // get out of the foreach
        }
    }
}

Om Prakash Pant · Answer 3 · 2011-08-17T01:05:00

Solution 3

if the value of textBox1.Text is blank, then do not set the parameter.

C#

string value_of_sno = textBox1.Text;
            cmd.Parameters.Add("@sno", value_of_sno);

and suggested by digimanu, set the parameters at the proper places.

Posted 17-Aug-11 1:05am

Om Prakash Pant

abhhy09 · Answer 4 · 2011-08-17T01:13:00

Solution 4

@usha nelavalli : Plz check that your data set is fill with all the records(by clicking on it in debugging mode)if it is fill with all the records the it will show result as u want.

Posted 17-Aug-11 1:13am

abhhy09