How do you draw a solid square with (*)'s using a while loop?

Question

0.00/5 (No votes)

See more:

I am currently trying to draw a solid square with (*)'s that is N length by N height using while loops but it returns as just a long line of (*)'s. Any help would be very much appreciated.

(Note: Sorry if this is a very novice question, I have only just begun to learn coding so please don't be too harsh, thank you :)).

What I have tried:

using System;
					
public class Program
{
	public static void Main()
	{
		var N = 5;
		var i = 0;
		
		while (N*N > i)
		{
			while (N > i)
			{
				Console.Write("*");
				i = i + 1;
			}
			Console.Write("\n");
		}
	}
}

Posted 20-Apr-19 22:08pm

QuantumNova

Updated 20-Apr-19 23:44pm

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2019-04-20T22:35:00

Solution 1

Think about it: can you really use the same variable in both loops?
You want two loops: one for rows, and one for columns:

while (more rows to do)
   set up for a row
   while (row not finished)
      print a star
   print a new line

N will remain the same for both loops, but you need separate X and Y counters.

Posted 20-Apr-19 22:35pm

OriginalGriff

Comments

QuantumNova 21-Apr-19 23:23pm

Thank you, this help was very much appreciated :)

OriginalGriff 22-Apr-19 1:44am

You're welcome!

Richard MacCutchan · Accepted Answer · 2019-04-20T22:37:00

Solution 2

You need to use a different counter for the inner loop. After printing the first 5 asterisks i will be equal to 6, so that loop will no longer be performed, and the outer loop will run forever. Try the following:

C#

while (N*N > i)
{
    var j = 0;
    while (N > j)
    {
        Console.Write("*");
        j = j + 1;
    }
    i += j;
    Console.Write("\n");
}

Posted 20-Apr-19 22:37pm

Richard MacCutchan

Comments

QuantumNova 21-Apr-19 23:23pm

Thanks so much, this really helped a lot, you are a lifesaver :)

Patrice T · Accepted Answer · 2019-04-20T22:55:00

Quote:
but it returns as just a long line of (*)'s.

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.