arrayList GetRange question

Question

0.00/5 (No votes)

See more:

hi everyone,The question is that is it right to use "GetRange" method to add new cards to player1 ' s arrayList?

C#

ArrayList cards = new ArrayList();
// i also create cards arrayList with "for".

ArrayList player1 = new ArrayList();
Random rnd = new Random();

for (int i = 0; i < 5; i++)
{
  int card = rnd.Next(0, cards.Count);
  player1.Add(cards.GetRange(card, 1))
  cards.RemoveAt(card);
}

Posted 24-Jan-12 3:04am

Member 8592678

Updated 24-Jan-12 3:07am

Richard MacCutchan

v2

Add a Solution

3 solutions

Solution 3

will work but there are certainly clearer ways to do this. One recommendation I have for you is to change from an ArrayList to a generic List<int> and then just index the List to retrieve your value.

i.e. something like the following

C#

List<int> cards = new List<int>();
List<int> player1 = new List<int>();
Random rnd = new Random();
for (int i = 0; i < 5; i++)
{
    int card = rnd.Next(0, cards.Count);
    player1.Add(cards[card]);
    cards.RemoveAt(card);
}

Posted 24-Jan-12 3:30am

LanFanNinja

Updated 24-Jan-12 3:33am

v4

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2012-01-24T03:22:00

Solution 2

It is syntactically correct (because a Add method accepts an object and an ArrayList, the return value of GetRange, is an object) but probably is NOT what you want to do, try instead:

C#

player1.Add(cards[card]));

This 'ambiguity' is a strong point in favour of strong typed collections ( :-) ), that is generic collections.

Posted 24-Jan-12 3:22am

CPallini

Comments

LanFanNinja 24-Jan-12 9:43am

+5 I agree.

Tim Groven · Accepted Answer · 2012-01-24T03:22:00

Solution 1

If you are only getting one item, I don't think GetRange is a good use. I would use it more for when you need to get more than one item.

I would just use:

player1.Add(cards[card]);

Posted 24-Jan-12 3:22am

Tim Groven

Comments

LanFanNinja 24-Jan-12 9:43am

+5 I would do the same.

Member 8592678 24-Jan-12 9:49am

but when i want to add multiple items can i use it?

Tim Groven 24-Jan-12 9:53am

Absolutely. Just remember, it returns a sequential range. :)