ArrayList is overwritten in vb.net Project

Question

0.00/5 (No votes)

See more:

Dear All,

I am very new to VB.net, I used ArrayList in a project and I observed that arraylist overwrites the previous items in the arraylist.

<serializable()> _
Public Class benchPortalPara

    Public name As String = ""
    Public attribute As String = ""
    Public time As Double = 0.0
    Public CmdCnt As Integer = 0 'ToDo: to remove

    <(XmlArrayItem(Type:=GetType(benchPortalPara)), _
    'XmlArrayItem(Type:=GetType(CLS_BENCH_CMD_ALARM))> _
    'Public benchList As ArrayList = New ArrayList

    <XmlArrayItem(Type:=GetType(benchPortalPara))> _
    Public benchList As ArrayList

    Public Shared Instance As benchPortalPara = Nothing

    Public Shared Sub passCmdData(ByVal Cls_Cmd As CLS_BENCH_CMD_TIMING)
        If (Instance Is Nothing) Then
            Instance = New benchPortalPara
        End If
        Instance.name = Cls_Cmd.cmdName
        Instance.attribute = Cls_Cmd.cmdDescription
        Instance.time = Cls_Cmd.duration
        Instance.CmdCnt += 1

        If (Instance.benchList Is Nothing) Then Instance.benchList = New ArrayList()
        Instance.benchList.Add(Instance)
    End Sub
End Class

Everytime when I call passCmdData() routine, my previous arraylist data is overwritten.

Please suggest that what can go wrong?

Thanks in advance,

Naveed

Posted 21-Feb-12 1:18am

naveed khowaja

Updated 21-Feb-12 1:19am

Varun Sareen

Add a Solution

Comments

Varun Sareen 21-Feb-12 7:19am

edit for: naveed khowaja

naveed khowaja 22-Feb-12 4:40am

Want to add something for your info, I am calling passCmdData() for 100 times. In this class I have declared my arraylist as "Public benchList As ArrayList".

do I need multi-dimentional arraylist for that? If so, how to implement it?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-02-21T01:54:00

Solution 1

Why does your class appear to hold an instance of itself, called Instance?
Why not use Me instead?

VB

If (Me.benchList Is Nothing) Then Me.benchList = New ArrayList()
Me.benchList.Add(Instance)

Posted 21-Feb-12 1:54am

OriginalGriff

Comments

naveed khowaja 21-Feb-12 20:42pm

Hi,

Thanks for the reply. But when I use Me instead of "instance" then it gives me following error.

"Me is only valid within an instance method"

OriginalGriff 22-Feb-12 4:00am

Then take off the "Shared" attribute.