cFileDialog DoModal Exception

Question

0.00/5 (No votes)

See more:

Dear All

I am getting following errors when I use the CFileDialog to open some files.

Sometimes It gives an exception "buffer OverRun" after selecting the specified file.

Sometime produce exception during the DoModal.

Can you please let me know what is wrong with this piece of code.

C++

CFileDialog dlg(TRUE);
dlg.m_pOFN->lpstrFileTitle = _T("Open Token File");
dlg.m_pOFN->nMaxFile       = 511;
dlg.m_pOFN->lpstrFilter = _T("TokenFile(*.tkn)\0*.tkn\0\0"); 
   
CString szFilePath;

dlg.m_pOFN->lpstrFile   = szFilePath.GetBuffer(10000);
if(dlg.DoModal() == IDOK)
{
	//szFilePath = dlg.GetFileName();
	m_txtFileName.SetWindowText(szFilePath);

}

Thanks
Sutha

Posted 28-Feb-12 23:45pm

tssutha03

Updated 28-Feb-12 23:48pm

Jochen Arndt

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2012-02-29T00:05:00

Do it this way ommitting the OFN structure:

C++

CFileDialog dlg(TRUE, NULL, NULL, OFN_HIDEREADONLY | OFN_OVERWRITEPROMPT, _T("TokenFile(*.tkn)|*.tkn||"));
if(dlg.DoModal() == IDOK)
{
	m_txtFileName.SetWindowText(dlg.GetFileName().GetString());
 
}

Your errors are:

lpstrFileTitle is the buffer to receive the selected file name, not the title for the dialog.
lpstrFilter can be also passed using the constructor. Note that '|' is used to separate the string.
lpstrFile is the file name to initialize the edit control, not the buffer to receive it. It may be also passed using the constructor.
UPDATE: When using GetBuffer() with CString, you must call ReleaseBuffer().