counting chars in a textarea still not working

Question

1.00/5 (1 vote)

See more:

hey guys.
i'm still trying to implement a quick char counter for a text area. problem is its not working even after changes i made instead of .innerHTML i worte .textContent
and insted of document.all['control'] i used getElementByID.
i'm attaching the code here, please help me get this working in other browsers except IE .

VB

function counter(method,cnt)    //accepts lang method and calc num of msgs
    {
        switch(method)
        {
            case 1 :
                if(cnt > 0 && cnt <= 70)
                    document.all('msgCounter').textContent = "1";
                if(cnt > 70 && cnt <= 134)
                    document.all('msgCounter').innerHTML = "2";
                if(cnt > 134 && cnt <= 201)
                    document.all('msgCounter').innerHTML = "3";
                if(cnt > 201 && cnt <= 268)
                    document.all('msgCounter').innerHTML = "4"; //tmp - need to determine limitation for msgs
                break;
            case 2 :
                if(cnt > 0 && cnt <= 160)
                    document.all('msgCounter').innerHTML = "1";
                if(cnt > 160 && cnt <= 306)
                    document.all('msgCounter').innerHTML = "2";
                if(cnt > 306 && cnt <= 459)
                    document.all('msgCounter').innerHTML = "3";
                break;
        }
        document.getElementById('chrCounter').innerHTML = cnt;
    }

Posted 31-Mar-12 21:35pm

moses12345

Add a Solution

Comments

Sergey Alexandrovich Kryukov 1-Apr-12 12:37pm

What is these two "methods"? What are those ranges 0..70, 134..201, etc? Where do you count characters? return result?
--SA

Sergey Alexandrovich Kryukov 1-Apr-12 22:40pm

And please do not re-post. I was supposed to remove this question and reply to your similar question:
http://www.codeproject.com/Questions/356408/using-javascript-to-count-chars-in-a-textarew-is-n

I did not do it by mistake. I also cannot see why did you ignore the advice by Peter_in_2780...
--SA

moses12345 2-Apr-12 6:36am

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2012-04-01T06:47:00

Solution 1

moses12345 wrote:
…insted of document.all['control'] I used getElementByID

No, you did not. Did you see you own code? You still use document.all, which is not a legal or standard property. Also, you calculate in several places, but you should calculate it only once. You can calculate the DOM element (textarea control, in this case), in the very first line of the function counter or pass it as a parameter of this function, and calculate the control reference once, in the caller, using document.getElementById (which is not document.getElementByID, look thoroughly).

You also need to answer the questions I asked in my comment to the question, first of all, answer for yourself. You need to add a loop, iterate throw the control's value, increment some character counter. You also need to return the counter value. You don't try to do anything of the above.

—SA

Posted 1-Apr-12 6:47am

Sergey Alexandrovich Kryukov

Comments

Peter_in_2780 1-Apr-12 22:14pm

I was going to say: What part of "Don't use document.all" didn't you understand?

Peter

Sergey Alexandrovich Kryukov 1-Apr-12 22:42pm

Do you mean, saying this to OP? Yes, I remember you did correctly advised that, but your advice was ignored.
It looks like OP get advices aggressively, looking at his response to my answer to his previous question.
Now, I'm expecting down-vote or something like that... :-)

Maybe I should not have answered... :-)
--SA

Peter_in_2780 1-Apr-12 22:54pm

Yeah, sorry. I meant saying to OP. Have a much heavier 5 than his 1 if it comes. ;)

Sergey Alexandrovich Kryukov 1-Apr-12 23:07pm

Ha-ha. Thank you, Peter.
--SA

moses12345 2-Apr-12 6:32am

ok guys, i pasted the wrong code, but i actually changed it
still not working . what im trying to do, is on every keyup event calculate the chars in the tectarea and write this counter result in a label.

Sergey Alexandrovich Kryukov 3-Apr-12 3:34am

If it means that you still need help, you can use "Improve question" above and enter your updated code, so we could see what's still need to be fixed.
--SA

Sergey Alexandrovich Kryukov 3-Apr-12 3:37am

checklist:
Do you add a loop by all characters?
Did you declare some counter variable inside function?
Did you increment counter in case of proper match of the character?
Did you return the counter from the function?
--SA