my php functrion always looping.

Question

4.00/5 (1 vote)

See more:

this is my function..

PHP

public function _GetResults($query)
        {
            $array = array();
            $result = mysql_query($query);
            if(!$result)
            {
                die('Invalid query: ' .mysql_error());
            }
            $array=mysql_fetch_assoc($result);
            return $array;
        }

this is my code to get the results, the results will display but it will not stop looping

XML

<?php

            echo "<table>";
            echo "<tr><th>First Name</th><th>Last Name</th></tr>";

            $Connection->_CreateConnections();
            $result = $Connection->_GetResults("select fname,lname from tblNames");

            while($result)
            {
                echo "<tr>";
                echo "<td>".$result["fname"]."</td>";
                echo "<td>".$result["lname"]."</td>";
                echo "</tr>";
            }

            echo "</table>";

            $Connection->_CloseConnections();
        ?>

the output goes like this

FIRSTNAME LASTNAME
john doe
john doe
john doe

Posted 23-Apr-12 22:34pm

newbie011292

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2012-04-23T22:45:00

Solution 1

I'm not a PHP expert, but I suspect you might have more luck if you used a foreach loop:

PHP

foreach ($result as $row)
{
    echo "<tr>";
    echo "<td>"$row["fname"]."</td>";
    echo "<td>"$row["lname"]."</td>";
    echo "</tr>";
}

Posted 23-Apr-12 22:45pm

OriginalGriff

Comments

Mohibur Rashid 24-Apr-12 4:46am

actually his mistake is understanding with the required function related with mysql

Mohibur Rashid · Answer 2 · 2012-04-23T22:45:00

it was suppose to do that.

look at this lines

PHP

            $result = $Connection->_GetResults("select fname,lname from tblNames");
//what does result contain? result contain an array, to d 
        ?>

to do it properly rewrite _GetResults as below:

PHP

public function _GetResults($query)
        {
            $array = array();
            $result = mysql_query($query);
            if(!$result)
            {
                die('Invalid query: ' .mysql_error());
            }
            return $result;
        }

also change the while loop as below:

PHP

while(($row=mysql_fetch_assoc($result)) //if row return null then the loop will terminate
  {
               echo "<tr>";
               echo "<td>".$row["fname"]."</td>";
               echo "<td>".$row["lname"]."</td>";
               echo "</tr>";
           }
mysql_free_result($result);//never forget this line