C# Passing Properties Between Winforms When Using Singleton

Question

3.33/5 (3 votes)

See more:

Ok so I am trying to pass a boolean from my Login form to my Home form, normally this would be fine for me and I would just use a property. However I thought I could use a similar method this time but I am implementing the singleton factory on the forms.

Here is the Login code relevant to this:
The AdminAccess property gets set fine and I have checked the value is correct.

C#

private bool adminAccess;

public bool  AdminAccess
        {
            get { return adminAccess; }
            private set { adminAccess = value; }
        }

private void btnLogin_Click(object sender, EventArgs e)
        {
            //Some Code Does Stuff
            
             OpenHome();
        }

private void OpenHome()
        {
            HomeForm CreateHomeForm = HomeForm.HomeUI;
            CreateHomeForm.StartupHome = this;

            //Trying to set the property.
            CreateHomeForm.AdminPermissions= this.AdminAccess;

            CreateHomeForm.Show();
            this.Hide();
        }

Here is the relevant code from the Home form:

C#

public HomeForm()
        {
            InitializeComponent();
            //just to check what is in the property quickly
            textBox1.Text = AdminPermissions.ToString();
        }

private bool adminPermissions;
public bool AdminPermissions
        {
            private get { return adminPermissions; }
            set { adminPermissions = value; }
        }

public Form StartupHome
        {
            set;
            get;
        }

private static HomeForm homeUI;
public static HomeForm HomeUI
        {
            get
            {
                if (homeUI == null || homeUI.IsDisposed)
                {
                    homeUI = new HomeForm();
                }
                return homeUI;
            }
        }

The value gets reset when the HomeUI if loop runs as a new instance of the form is created. I can't seem to think how to modify this to get a working solution. As you can tell I am fairly amateur so I'm just looking for a quick and clean solution to this :)
Thank you very much for your time in advance!

Posted 24-Apr-12 4:10am

Jack Eker

Add a Solution

Comments

Sergey Alexandrovich Kryukov 24-Apr-12 12:01pm

And where is your singleton?
--SA

3 solutions

Solution 1

Why don't you just pass the value through the HomeForm constructor?

Posted 24-Apr-12 4:26am

Wes Aday

Comments

Jack Eker 24-Apr-12 10:39am

I tried that and I get an error trying to pass anything inside the "homeUI = new HomeForm();" constructor :S

[no name] 24-Apr-12 10:55am

What does "an error" mean?

Solution 3

This is the popular question about form collaboration. The most robust solution is implementation of an appropriate interface in form class and passing the interface reference instead of reference to a "whole instance" of a Form. Please see my past solution for more detail: How to copy all the items between listboxes in two forms[^].

—SA

Posted 24-Apr-12 6:02am

Sergey Alexandrovich Kryukov

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jack Eker · Accepted Answer · 2012-04-24T05:16:00

The solution I have come to is as follows:

C#

public HomeForm()
        {
            InitializeComponent();
        }

private void HomeForm_Shown(object sender, EventArgs e)
        {
            if (AdminPermissions)
            {
                btnCreateUser.Visible = true;
            }
            else
            {
                btnCreateUser.Visible = false;
            }
        }

private bool adminPermissions;
public bool AdminPermissions
        {
            get { return adminPermissions; }
            set { adminPermissions = value; }
        }

public Form StartupHome
        {
            set;
            get;
        }

private static HomeForm homeUI;
public static HomeForm HomeUI
        {
            get
            {
                if (homeUI == null || homeUI.IsDisposed)
                {
                    homeUI = new HomeForm();
                }
                return homeUI;
            }
        }