store procedure error

Question

0.00/5 (No votes)

See more:

SQL-Server-2005

first i have mention that i m very new to this asp.net so plese if my error is to small then also give me the answer....
i have made one store procedure name insertstudent and its look like.
create procedure insertstudent @firstname varchar(50),@lastname varchar(50),@gender varchar(50),@address varchar(50),@phone varchar(50),@dob datetime,@email varchar(50)
as
insert into student values(@firstname varchar(50),@lastname varchar(50),@gender varchar(50),@address varchar(50),@phone varchar(50),@dob datetime,@email varchar(50))
and i m getting error like..
Msg 102, Level 15, State 1, Procedure insertstudent, Line 3
Incorrect syntax near 'varchar'.
i couldnt find the error...plese anyone help me....

Posted 22-Jul-12 9:04am

pandya purvang

Add a Solution

Comments

[no name] 22-Jul-12 15:09pm

insert into student values(@firstname,@lastname,@gender,@address,@phone,@dob ,@email)

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

abhinavvijay · Answer 1 · 2012-07-22T09:13:00

Solution 1

you should write below code

SQL

create procedure insertstudent
@firstname varchar(50),@lastname varchar(50),@gender varchar(50),@address varchar(50),@phone varchar(50),@dob datetime,@email varchar(50)
as
insert into student values(@firstname,@lastname ,@gender ,@address ,@phone ,@dob ,@email )

Posted 22-Jul-12 9:13am

abhinavvijay

Comments

pandya purvang 22-Jul-12 15:17pm

Thanks man its working..............thanks lot!!

db7uk · Answer 2 · 2012-07-22T09:16:00

Your insert is not correct.

It should read

SQL

Insert into Student( firstname, lastname, gender, address, phone, dob, email)
values (@firstname, @lastname, @gender, @address, @phone, @dob, @email)

Basically the insert line (line 1) should be the columns you want to insert into.
The second (values line 2) should be the values of the parameters.

You could re-write this to (Providing that the columns in your table are in the same order as the parameters):

SQL

insert into Student
select @firstname, @lastname, @gender, @address, @phone, @dob, @email