Stored Procedure Returns Null

Question

1.00/5 (1 vote)

See more:

Hi
I'm trying to create a stored procedure that returns a balance of values taken from two different tables, can u please look at it and correct my logic or syntax error?

SQL

Create Proc [dbo].[GetAmntPaid](
@QNo int)
As
Begin
Select Quote.FullAmt - IsNull(Payments.AmountPaid ,0) As Balance from Quote, Payments 
where Quote.QuoteNo = Payments.QuoteNo
And @QNo = Quote.QuoteNo 
End

Thank you in advance
Regards

Posted 10-Sep-12 0:35am

mlingo209

Add a Solution

Comments

dimpledevani 10-Sep-12 6:38am

Quote.FullAmt can be null,Check that too

__TR__ 10-Sep-12 6:39am

Try
Select ISNULL(Quote.FullAmt,0) - IsNull(Payments.AmountPaid ,0) As Balance from Quote, Payments
where Quote.QuoteNo = Payments.QuoteNo
And Quote.QuoteNo = @QNo

mlingo209 10-Sep-12 6:46am

Still returns null

2 solutions

Solution 1

Try this one :-

SQL

Create Proc [dbo].[GetAmntPaid](
@QNo int)
As
Begin
Select Quote.FullAmt - IsNull(Payments.AmountPaid ,0) As Balance from Quote, Payments
where Quote.QuoteNo = Payments.QuoteNo
And Quote.QuoteNo = @QNo
End

Posted 10-Sep-12 0:38am

Sunil Kumar Pandab

Comments

mlingo209 10-Sep-12 6:46am

It is still returning nothing

mlingo209 10-Sep-12 10:16am

Will it work if the input parameter qno does not exist in Payments table?

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

mlingo209 · Accepted Answer · 2012-09-10T04:47:00

Solution 2

Hey Guys It may seem that I might have forgotten crucial piece of info the row might not exist at all in the 2nd table hence why IsNull wasn't working.

SQL

ALTER Proc [dbo].[GetAmntPaid](
@QNo int)
As
Begin
Select IsNull(Quote.FullAmt, 0.00)  - IsNull(Payments.AmountPaid ,0.00) 
from Quote
Left Join Payments on  Quote.QuoteNo = Payments.QuoteNo 
Where Quote.QuoteNo = @QNo
End

This works perfectly
Regards

Posted 10-Sep-12 4:47am

mlingo209

Comments

Maciej Los 10-Sep-12 16:39pm

JOIN statement and ISNULL with correct numeric format (0.00) - This is it!
+5!

Maciej Los 10-Sep-12 16:41pm

Formally - mark this answer as "solved".