simple program not counting down

Question

0.00/5 (No votes)

See more:

hi im very new to c and i decided to write this program, can anyone tell me why its not counting down from the number entered to 0?

C++

#include <stdio.h>

int printloop(int k )
{
    int b;
        for (b = k; b < 0; b--)
     printf("%d\n",b);
}

int main()
{
int c;

scanf("%d",&c);
if( c > '0' && c < '6')

printloop(c);

return 0;
}

Posted 25-Sep-12 8:14am

flaringdon

Updated 25-Sep-12 8:19am

Kenneth Haugland

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2012-09-25T08:21:00

Solution 1

To start with:

C++

if( c > '0' && c < '6')

c is an integer defined but you compare it with a character '0' & '6'. Remove quotes around 0 & 6

Posted 25-Sep-12 8:21am

Sandeep Mewara

Comments

Sergey Alexandrovich Kryukov 25-Sep-12 14:26pm

One bug nailed down, a 5.
--SA

Sandeep Mewara 25-Sep-12 14:29pm

Thanks SA.

fjdiewornncalwe 25-Sep-12 14:32pm

+5 for the "other" issue.

Sandeep Mewara 25-Sep-12 14:39pm

:)

ridoy 25-Sep-12 15:29pm

+5

fjdiewornncalwe · Accepted Answer · 2012-09-25T08:25:00

Solution 2

Because in your for (b = k; b < 0; b--), you aren't allowing it to do any work.
The second clause "b<0" indicates that this loop will only run if b < 0.
Since you set b == k which is greater than 0, the loop will not run.
Your solution is for (b = k; b >= 0; b--)

Posted 25-Sep-12 8:25am

fjdiewornncalwe

Comments

Sergey Alexandrovich Kryukov 25-Sep-12 14:26pm

Another bug nailed down, a 5.
--SA

fjdiewornncalwe 25-Sep-12 14:32pm

That error was simply too common a mistake that rookies make. I've learned a long time ago to always check the for loop args before anything else when someone says the loop isn't doing anything. Thanks.

Sergey Alexandrovich Kryukov 25-Sep-12 17:41pm

Sure...
--SA

Sandeep Mewara 25-Sep-12 14:29pm

5! Marcus!

:)

fjdiewornncalwe 25-Sep-12 14:32pm

Thanks Sandeep.

flaringdon 25-Sep-12 14:34pm

thanks marcus and sandeep

ridoy 25-Sep-12 15:29pm

+5