error in swaping images

Question

0.00/5 (No votes)

See more:

I am using the following codes to swap images one after another but only the image mentioned in <img> tag is displayed. The images are not swaping as i want. please help me.

XML

<html>
<head>
<script language="javascript">
(function(){
 var rotator=document.getElementById('rotator');
 var imageDir='';
 var delayInSeconds=2;
 var images=['2.jpg','3.jpg','4.jpg','5.jpg','4.jpg'];

 var num=0;
 var changeImage=function(){
    var len=images.length;
    rotator.src=imageDir+images[num++];
    if(num==len){
        num=0;
        }
    };
    setInterval(changeImage, delayInSeconds * 1000);
    })();
</script>
</head>
<body>
    <img src="4.jpg" alt="rotating image" width="700" height="600" id="rotator">
</body>
</html>

Posted 4-Oct-12 5:15am

Ramesh2905

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graham Breach · Answer 1 · 2012-10-04T05:45:00

Solution 1

You are trying to get a reference to the image element in your main closure, before the document has loaded.

If you move the var rotator=... line inside the changeImage function, it should work.

Posted 4-Oct-12 5:45am

Graham Breach