C# print out number of sellers for each level

Question

0.00/5 (No votes)

See more:

Hi!

I'm very new to C# and is having a bit of a loop problem.

At the moment I have a group of sellers that needs to be counted by the amount of articles sold. They are already assigned to their respective level by the following conditions:

C#

if (seller[i].articles < 50)
    seller[i].level = 1;

if (seller[i].articles >= 50 && seller[i].articles < 100)
    seller[i].level = 2;

if (seller[i].articles >= 100 && seller[i].articles < 200)
    seller[i].level = 3;

if (seller[i].articles >= 200)
    seller[i].level = 4;

However, a slight problem arises when I want to count how many of the sellers that actually are in respective level.
This might lend a clue to figure out what I'm trying to achieve:

C#

            int count = 0;
            for (int i = 0; i < 3; i++)
            {
                if (seller[i].level == i) 
                    count++;
Console.WriteLine("Numbers of sellers in level {0}: {1}", seller[i].level, count);

            }

Regards,
L

Posted 26-Oct-12 15:20pm

leprechauny

Updated 26-Oct-12 15:32pm

v2

Add a Solution

Comments

leprechauny 29-Oct-12 16:41pm

Well, as indicated and correctly assumed there are only four levels. So exactly as you suggest I think it's plausible to use an array to hold the different levels. However, the real number of sellers are six. But is that really an issue? That is, the numbers of sellers ought to be irrelevant when you determine which level has that been reached.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Garth J Lancaster · Answer 1 · 2012-10-26T17:34:00

I'd almost be tempted to do something like this ..

// store the count of sellers at each level
// see the discussion about the number of elements in this array
int[] levels = new int[5] {0, 0, 0, 0, 0};

and then when you do

if (seller[i].articles < 50)
        seller[i].level = 1;

that becomes something like :-

if (seller[i].articles < 50) 
(
    seller[i].level = 1;
    levels[seller[i].level] += 1;
    // or levels[1] += 1;
)

...and so forth so all the calcs are done in one pass, unlike what you suggest

the only issue I have even with my own approach, is that arrays are indexed by '0', therefore levels[0] is wasted in the above (but there's a correspondance to your levels 1-4)

I'd have to think if

int[] levels = new int[4] {0, 0, 0, 0};

and using

// note the -1 below to map levels 1-4 to array 0-3
levels[seller[i].level -1] += 1;

is better.

I don't know if anyone else agrees or not, but I hate traversing data sets multiple times where a single pass will do ...

Since you only indicate 4 levels, I think an array is justified - if you had an arbitrary number of levels I'd likely use a hash-map or such where seller[i].level -1 is the index in the hash-map and count is the value

I still worry (probably too much about what I dont see here - if ths is the only place in the code that modifies levels[], then ok, else I'd be thinking about checking that either seller[i].level or seller[i].level -1 was in the range of the array bounds, also depending on the decision or not to map your levels 1-4 to the array subscripts 0-3

thats my 2 cents worth