Comparing the "last modified date" to todays date

Question

0.00/5 (No votes)

See more:

Greetings,

I am writing a small utility that compares the 'Last modified' attribute on all files in a folder, and if they are X amount of days old, deletes them.

Can someone give me a more elegant way to do this than what I have come up with?

DateTime fileModDate = File.GetLastWriteTime(f);
int result = DateTime.Compare(fileModDate.AddDays(intDays), today);
if (result < 0)
{
    File.Delete(f);
}

Posted 4-Jan-10 10:56am

Dbloom

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Christian Graus · Accepted Answer · 2010-01-04T11:07:00

No, I don't think there's any simpler way of writing this code. I'd put the File.Delete in a try/catch and consider checking if files are read only, but that adds code, it does not subtract it.

wrote:
intDays

Just to add - Hungarian notation went out of fashion as soon as the Hungarian stopped working for Microsoft.

AspDotNetDev · Accepted Answer · 2010-01-04T11:25:00

I'd probably do it like this:

C#

DateTime firstValidDate = DateTime.Now.AddDays(-days);
DateTime fileModDate = File.GetLastWriteTime(f);
if (fileModDate < firstValidDate) File.Delete(f);

You can calculate firstValidDate in advance then use it in a loop (such as a loop over each file in a folder) without recalculating again. Note that there is also no need to use the Compare method (you can just use comparison operators).

Comparing the "last modified date" to todays date

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0