How to use asynchronous method in C# to avoid execution time?

Question

1.00/5 (1 vote)

See more:

I have usersIds list for each one has 200 above secuirty roles.
I have userd the below code to execute but taking lot of time.
Could you please give the suggestion that what is the best approach for this type of scenarios in C#

List<SRInformation> objSrInformation = new List<SRInformation>();
//UserList 250
foreach(int userId in userList)
{
      List<SRInformation> SRInformationlist = new List<SRInformation>();
      List<int> srList =new List<int>();
      srList = GetSRListByUserID(id);
      //SR List each one conatin min 200
      foreach(int srId in srList)
      {
	SRInformationlist = GetDetailsBySRId(srID)
        objSrInformation.Add(SRInformationlist);
      }
      
}

What I have tried:

I have tried

List<SRInformation> objSrInformation = new List<SRInformation>();
//UserList 250
foreach(int userId in userList)
{
      List<SRInformation> SRInformationlist = new List<SRInformation>();
      List<int> srList =new List<int>();
      srList = GetSRListByUserID(id);
      //SR List each one conatin min 200
      foreach(int srId in srList)
      {
	SRInformationlist = GetDetailsBySRId(srID)
        objSrInformation.Add(SRInformationlist);
      }
      
}

Posted 16-Jul-19 4:26am

DGKumar

Updated 16-Jul-19 4:45am

Add a Solution

Comments

Richard Deeming 16-Jul-19 13:45pm

objSrInformation.Add(SRInformationlist);

That line won't compile. Did you mean AddRange?

List<int> srList = new List<int>();
srList = GetSRListByUserID(id);

Why create a new object if you're just going to throw it away without using it?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2019-07-16T04:45:00

We can't tell, we have no idea where it is slow - let alone why.
Start by profiling your app and finding out where it's taking time, and how much it's actually taking. Then you can start f]think about ways to improve it, and have a benchmark for how big an improvement you are getting. Manual profiling would involve adding Stopwatch class[^] instances to your code, and logging the time various bits take, or you can use the Visual Studio profiler[^] if your version of VS supports it.

Chances are that multithreading won't help significantly unless it's targeted at parallelable bottlenecks - it's not a magic bullet, it involves adding threads (which add processing time to support) each of which needs a free core to execute. Once all the cores in your machine are in use, thread get suspended waiting for a free one and do not run until one is available. Adding threads indiscriminately can slow applications significantly as each thread uses more memory and requires extra processing power to manage and switch the threads.