What's the difference between the 2 codes from the following links?

Question

0.00/5 (No votes)

See more:

https://code.sololearn.com/cnqkkc7wuCRy/?ref=app
and
https://code.sololearn.com/c802fPXTx057/?ref=app
Do these 2 programs differ ?
If yes, then how so ?
Which one's better ?

What I have tried:

def largest(a,b,c):
	if a>b and a>c:
		print(a)
	if b>a and b>c:
		print(b)
	else:
		print(c)
largest(1,4,7)

```

def max_of_three(a,b,c):
     max_3=0
     if a>b:
         #max_3=a
         if a>c:
             max_3=c
         else:
             max_3=a
     else:
          if b>c:
             max_3=b
          else:
             max_3=c
     return max_3
print(max_of_three(1,4,7))

Posted 3-Jan-20 4:25am

maverickreal

Updated 3-Jan-20 4:42am

Add a Solution

Comments

Richard MacCutchan 3-Jan-20 10:31am

The first one makes most sense.

maverickreal 3-Jan-20 10:35am

Oh I see . Thanks.

Richard MacCutchan 3-Jan-20 10:40am

If you look closely there is also a bug in the second one, in that it will return the value of c for a call where a is greater than both b and c.

maverickreal 3-Jan-20 10:43am

Ya that i knew. 👍🏽

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-01-03T04:42:00

Both have good and bad features:
The first is more obvious and readable, but the second is more flexible.
A better solution would be to use the logic of the first example, but return a value instead of printing it inside the function.

That way, you get readability and flexibility because the same function can be used from more places:

def largest(a,b,c):
	if a>b and a>c:
		return a
	if b>a and b>c:
		return b
	return c
print(largest(1,4,7))