how to check one if at a time. help me with this. THANX

Question

0.00/5 (No votes)

See more:

C#

if (cboaccount1.Text != "" || cboaccount2.Text != "" ||cbotitle.Text != "")
               {
                   if (!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
                       MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                       cboname.SelectAll();
                       cboname.Focus();
                   }

Posted 14-Jan-13 10:37am

zeshanazam

Add a Solution

Comments

David_Wimbley 14-Jan-13 16:39pm

your question is not clear and your code snippet doesnt even resemble what...to me...i think your title does. Please use the Improve Question widget to make your question more clear.

zeshanazam 14-Jan-13 16:42pm

i want to check first
if (cboaccount1.Text != "" || cboaccount2.Text != "" ||cbotitle.Text != "")
if it is not true then
if (!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
cboname.SelectAll();
cboname.Focus();
}

but both working at a same time..

David_Wimbley 14-Jan-13 16:48pm

Is this what you need then?

if (cboaccount1.Text != "" || cboaccount2.Text != "" || cbotitle.Text != "")
{

}
else
{
if (!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
{
MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
}

cboname.SelectAll();
cboname.Focus();
}

zeshanazam 14-Jan-13 16:52pm

oh sorry i want to check
if
if (cboaccount1.Text != "" || cboaccount2.Text != "" ||cbotitle.Text != "")
it is true then
if (!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success) MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error); cboname.SelectAll(); cboname.Focus(); }

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard C Bishop · Answer 1 · 2013-01-14T10:51:00

Solution 1

You need to nest your if statement for the second portion. It should look like this:

C#

if (cboaccount1.Text != "" || cboaccount2.Text != "" || cbotitle.Text != "")
               {
                 if(!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
                 {
 MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                       cboname.SelectAll();
                       cboname.Focus();
                 }
              }

Posted 14-Jan-13 10:51am

Richard C Bishop

Updated 14-Jan-13 11:24am

v4

Comments

zeshanazam 14-Jan-13 17:11pm

what is wrong with this ??

if (cboaccount1.Text == "" && cboaccount2.Text == "" && cbotitle.Text == "" && cboname.Text == "")
{
MessageBox.Show("Plz Provide Some Field", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);

cboaccount1.Focus();

}
else

if (cbotitle.Text != "" ||cboname.Text!="")
{
}
else if (!Regex.Match(cboaccount1.Text, @"^[0-9]{4}$").Success)
{
MessageBox.Show("Invalid Account NO\nShould be of type e.g 8459-5", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
cboaccount1.SelectAll();
cboaccount1.Focus();
}
else if (!Regex.Match(cboaccount2.Text, @"^[0-9]{1}$").Success)
{
MessageBox.Show("Invalid Account No", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
cboaccount2.SelectAll();
cboaccount2.Focus();
}

else
{
if (cboaccount1.Text != "" || cboaccount2.Text != "" || cbotitle.Text != "")
{
}

else if (!Regex.Match(cboname.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
{
MessageBox.Show("Invalid Name", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
cboname.SelectAll();
cboname.Focus();
}
else
{
if (cboaccount1.Text != "" || cboaccount2.Text != "" || cboname.Text != "")
{
}
else if (!Regex.Match(cbotitle.Text, @"^[A-Za-z][A-Za-z. ]*$").Success)
{
MessageBox.Show("Invalid title", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
cbotitle.SelectAll();
cbotitle.Focus();
}

else
{

SqlCommand cmd = new SqlCommand("Select * from Accounts where Account_No='" + cboaccount1.Text + "-" + cboaccount2.Text + "'or Account_title= '" + cbotitle.Text + "'or Name='" + cboname.Text + "'", cn);
cmd.CommandType = CommandType.Text;
da = new SqlDataAdapter(cmd);
DataSet ds = new DataSet();
da.Fill(ds, "ss");

if (ds.Tables[0].Rows.Count == 0)
{
MessageBox.Show("No Record Exist", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
}
else
{
acse.dataGridView1.DataSource = ds.Tables["ss"];
this.Hide();
acse.ShowDialog();
this.Close();
}
}

}
}

Richard C Bishop 14-Jan-13 17:24pm

Can you add that code using the "Improve Question" widget please? I cannot read that in the comment box.

Sergey Alexandrovich Kryukov · Answer 2 · 2013-01-14T10:51:00

Here is exactly the difference between '&' and '&&', '|' and '||'.

The operator using double characters "optimizes" the check: the expression is evaluated left-to-righ. The evaluation is performed only until it makes sense, from the standpoint of final Boolean value. Further evaluation is not performed when the result of it is already known from already complete evaluation steps. In particular, in the sequence of '&&' operators, when some intermediate result if false, further evaluation is not performed, because none of next members can possibly change the result to true, because false & true is always false anyway. Likewise, in the sequence of '||' operators, when some intermediate result if true, further evaluation is not performed, because none of next members can possibly change the result to false, because true | false is always true, anyway.

Isn't that clear?

Now, it's can possibly still give a wrong execution, not in the Boolean result, but in side-effect of some function, when some members of Boolean expressions are Boolean function with some side effect. This way, some calls to those function can be "optimized out", so the side effects will be skipped.

One approach to resolve this would be using '|' or '&'. Another, generally better approach would be avoiding using Boolean functions with side effects, at least in Boolean expressions. A number of computer languages does not allow such function at the level of compilation.

Now, armed with this understanding, you can get full control over execution of your Boolean expression. This is all you want to know. Of course, sometime you also may prefer using (nested) if blocks, where everything is explicit.

—SA