Else part is not executing

Question

1.00/5 (1 vote)

See more:

unable to run following js code
else part is not executing

What I have tried:

JavaScript

if ((m1 < 40) || (m2 < 40) || (m3 < 40) || (m4 < 40) || (m5 < 40) || (m6 < 40)) {
    result = "Fail";
    grade = "f";
}

else {
    var mm = avg;
    if (mm >= 80) {
        grade = "A";
        result = "Distinction";
    }
    elseif(mm >= 60)
    {
        grade = "B"
        result = "Firstclass";
    }
    elseif(mm >= 50)
    {
        grade = "C";
        result = "Secondclass";
    }
    elseif(mm >= 40)
    {
        grade = "D";
        result = "Pass";
    }
    elseif(mm < 40)
    {
        grade = "F";
        result = "Fail";
    }
}

Posted 18-Aug-20 21:01pm

Sanjay Taak

Updated 19-Aug-20 1:13am

Patrice T

v2

Add a Solution

Comments

Richard MacCutchan 19-Aug-20 3:03am

One of those values (m1, m2 ...) must be less than 40. And where do you get the value of avg from?

Sanjay Taak 20-Aug-20 0:32am

var total = (m1 + m2 + m3 + m4 + m5 + m6);
//var avg = (total / 600) * 100;
var avg = Math.round(total / 6);

[no name] 19-Aug-20 3:04am

And what are the values for 'm1'...'m6' you are testing with?

Sanjay Taak 20-Aug-20 0:33am

var m1 = parseInt(document.frmStudent.mark1.value);
var m2 = parseInt(document.frmStudent.mark2.value);
var m3 = parseInt(document.frmStudent.mark3.value);
var m4 = parseInt(document.frmStudent.mark4.value);
var m5 = parseInt(document.frmStudent.mark5.value);
var m6 = parseInt(document.frmStudent.mark6.value);

Sanjay Taak 20-Aug-20 0:34am

values for m1m2.....is greater than 40 only

Richard MacCutchan 20-Aug-20 4:24am

You need to show the actual numbers, we don't care where they come from.

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-08-18T21:19:00

We can't run that code in isolation and get the same results you do - we have no access to the values you are using for testing.
So, it's going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. How you use it depends on your browser, but a quick Google for the name and "debugger" should give you the info you need.
For Chrome, you will find lots of info here: Get Started with Debugging JavaScript in Chrome DevTools[^]
Otehr browsers wiull have similar facilities.

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!

Patrice T · Answer 2 · 2020-08-18T22:16:00

Quote:
unable to run following js code

We can't either because we don't know the value of the 7 variable the code depend on.

JavaScript

m1= ?; // Give sample values that lead to unexpected result
m2= ?;
m3= ?;
m4= ?;
m5= ?;
m6= ?;
avg= ?;
if ((m1 < 40) || (m2 < 40) || (m3 < 40) || (m4 < 40) || (m5 < 40) || (m6 < 40)) {
    result = "Fail";
    grade = "f";
}

else {
    var mm = avg;
    if (mm >= 80) {
        grade = "A";
        result = "Distinction";
    }
    elseif(mm >= 60)
    {
        grade = "B"
        result = "Firstclass";
    }
    elseif(mm >= 50)
    {
        grade = "C";
        result = "Secondclass";
    }
    elseif(mm >= 40)
    {
        grade = "D";
        result = "Pass";
    }
    elseif(mm < 40)
    {
        grade = "F";
        result = "Fail";
    }
}

Richard MacCutchan · Answer 3 · 2020-08-18T22:51:00

Solution 3

It occurs to me that your problem is to do with using the wrong operator. You have the following:

JavaScript

if ((m1 < 40) || (m2 < 40) || (m3 < 40) || (m4 < 40) || (m5 < 40) || (m6 < 40)) {
    result = "Fail";
    grade = "f";
}

else {
    var mm = avg;
    // code removed for readability
}

This means that if any of those values are less than 40 then the result is a grade f fail. However, what if m2, m3,m4,m5 and m6 are all above 80? That would raise the average to a higher grade pass. So what I think you mean is:

JavaScript

if ((m1 < 40) && (m2 < 40) && (m3 < 40) && (m4 < 40) && (m5 < 40) && (m6 < 40)) {
    result = "Fail";
    grade = "f";
}
else {
    var mm = avg;
    // code removed for readability
}

Which makes more sense in that all the scores would need to be below 40 for a fail.

Posted 18-Aug-20 22:51pm

Richard MacCutchan

Comments

Patrice T 19-Aug-20 5:00am

not necessary a wrong operator.
a fail if 1 value below 40 makes sense to me.

Richard MacCutchan 19-Aug-20 5:19am

So if you have 89,82,84,85,80,32: average 76.6 you think that should be a fail? That makes no sense to me. In fact, according to the tests in the else clause, that would be a grade B First class pass.

Patrice T 19-Aug-20 5:30am

I have seen such kind of rules.

Richard MacCutchan 19-Aug-20 5:35am

But that is irrelevant.

Patrice T 19-Aug-20 5:37am

only OP can tell us :)

Richard MacCutchan 19-Aug-20 6:12am

That is exactly my point.

Sanjay Taak 20-Aug-20 0:38am

bro if fail in one sub than you will be consirded fail only

Richard MacCutchan 20-Aug-20 4:23am

OK, but that does not help in finding out why the else clause is never executed. You need to run the code in the debugger and examine every variable to see what is happening.

But as I showed above, it is possible to fail one subject and still have an average which would merit a pass.

Sanjay Taak 22-Aug-20 2:59am

bro in the above code elseif should be suppreted with a space because the code is javascript hence it will be else if

Richard MacCutchan 22-Aug-20 3:20am

Well done, you have solved your problem.

W∴ Balboos, *GHB* · Answer 4 · 2020-08-19T01:14:00

When you set mm=avg and avg has not been declared then you have an error condition.

javaScript halts at that point - more than likely without an error message of any kind.

Also, wouldn't it make sense to calculate the avg before any test for the grades? Unless the entire grade depends upon any one test of the six (in most situations, quite unfair). Then the <40 can be taken care of in the switch and that block, testing each exam score for failure, can be removed. In fact, you already do this in your switch so you were expecting to get to that point, anyway !

So that gets rid of your 'if' and that means you also get rid of the else: it's just a switch that you need - and you need to calculate that value 'avg'. Also, if you already have the value for 'avg', why would you then copy it to mm and test it there? Just use 'avg' in the switch argument.

Another thing to consider: put your scores in an array. You can then have any number of scores for your exam and keep track of the student's status at any time without having to worry about handling zeroes for yet-undertaken exams.

All of his, of course, based upon the code you have shown, only

Else part is not executing

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0