Parse error: syntax error, unexpected '$files' (T_VARIABLE), expecting '(' in C:\wamp64\www\johnsite\downloadfile\index.php on line 28

Question

0.00/5 (No votes)

See more:

am trying to run code for download but i keep getting this problem,below are my codes
index php

<?php include 'filesLogic.php';?>
<!DOCTYPE html>

<html lang="en">
  <head>
    <link rel="stylesheet" href="style.css">
    <title>Files Upload and Download</title>
  </head>
  <body>
    <div class="container">
      <div class="row">
        <form action="index.php" method="post" enctype="multipart/form-data" >
          <h3>Upload File</h3>
          <input type="file" name="myfile"> <br>
          <button type="submit" name="save">upload</button>
        </form>
      </div>
    </div>
	<table>
<thead>
    <th>ID</th>
    <th>Filename</th>
    <th>size (in mb)</th>
    <th>Downloads</th>
    <th>Action</th>
</thead>
<tbody>
  <?php foreach $files as $file; ?>
    <tr>
      <td><?php echo $file['id']; ?></td>
      <td><?php echo $file['name']; ?></td>
      <td><?php echo floor($file['size'] / 1000) . ' KB'; ?></td>
      <td><?php echo $file['downloads']; ?></td>
      <td><a href="downloads.php?file_id=<?php echo $file['id'] ?>">Download</a></td>
    </tr>
  <?php endforeach;?>

</tbody>
</table>
  </body>
</html>

filesLogic.php

<?php
// connect to the database
$conn = mysqli_connect('localhost', 'root', '', 'personal');
if(!$conn){
		die("Fatal Error: Connection Failed!");
	}
?>

downloads.php

<?php
	include 'filesLogic.php';
 	// Downloads files
if (isset($_GET['file_id'])) {
    $id = $_GET['file_id'];

    // fetch file to download from database
    $sql = "SELECT * FROM try WHERE id=$id";
    $result = mysqli_query($conn, $sql);

    $file = mysqli_fetch_assoc($result);
    $filepath = 'uploads/' . $file['name'];

    if (file_exists($filepath)) {
        header('Content-Description: File Transfer');
        header('Content-Type: application/octet-stream');
        header('Content-Disposition: attachment; filename=' . basename($filepath));
        header('Expires: 0');
        header('Cache-Control: must-revalidate');
        header('Pragma: public');
        header('Content-Length: ' . filesize('uploads/' . $file['name']));
        readfile('uploads/' . $file['name']);

        // Now update downloads count
        $newCount = $file['downloads'] + 1;
        $updateQuery = "UPDATE try SET downloads=$newCount WHERE id=$id";
        mysqli_query($conn, $updateQuery);
        exit;
    }
}
?>

What I have tried:

have tried to paste the index php into another code but i keep getting the same problem

Posted 8-Feb-21 9:17am

Member 15067930

Updated 8-Feb-21 14:49pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Luc Pattyn · Accepted Answer · 2021-02-08T14:49:00

Solution 1

Hi,

When a compiler tells you it got an unexpected something, that really means right before that something something is lacking.

As the documentation[^] clearly shows, in PHP foreach requires parentheses.

You probably need to pay more attention to documentation or examples, the next likely problem you'll have is endforeach does not exist as a keyword. You're too creative!

:)

Posted 8-Feb-21 14:49pm

Luc Pattyn

Updated 8-Feb-21 14:51pm

v2

Comments

Member 15067930 9-Feb-21 12:07pm

can you please re-write how the code is suppose to be,am new in php,i will appreaciate.

Luc Pattyn 9-Feb-21 12:19pm

You can't loop HTML code like that, put all the loop stuff inside PHP, like so (using period to concatenate strings, and semicolon to terminate PHP instructions):

<?PHP
foreach ($files as $file) {
echo "<tr>";
echo "<td>".$file['id']."</td>";
echo "<td>".$file['name']."</td>";
...
echo "</tr>";

}
?>