Incorrect syntax near '='. => Sqldatareader dr = cmd.executereader();

Question

1.00/5 (1 vote)

See more:

public bool IsCorrectUser(string userId, string password)
{
bool result = false;

con.Open();

SqlCommand cmd = new SqlCommand();

cmd.Connection = con;
cmd.CommandText = "Select * From Users" + "Where UserID = @UserID And Password = @Password";
cmd.CommandType = CommandType.Text;

cmd.Parameters.AddWithValue("@UserID", userId);
cmd.Parameters.AddWithValue("@Password", password);

SqlDataReader dr = cmd.ExecuteReader();

if (dr.Read())
{
result = true;
}

dr.Close();
con.Close();

return result;
}

What I have tried:

I don't know what is wrong.........

Posted 25-Mar-21 18:35pm

LeeHyungJin1995

Updated 25-Mar-21 18:59pm

Add a Solution

Comments

Richard Deeming 26-Mar-21 5:42am

You're storing your users' passwords in plain text. Don't do that.

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2021-03-25T18:59:00

Space is missing in the query:

C#

cmd.CommandText = "Select * From Users" + "Where UserID = @UserID And Password = @Password";

If you DEBUG, you can see the commandText is:

SQL

Select * From UsersWhere UserID = @UserID And Password = @Password

Add space between Users & Where words.

Debugging is part of your learning. When you move step by step, you will be able to find such mistakes easily.