Click here to Skip to main content
15,031,495 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
What I want is when a new teacher is added, it will create a table in the database with the name $param_subject1. It does create the table but I also want to insert the information of the new teacher in that created table.

PHP
try{
                       $sql2 = "CREATE TABLE IF NOT EXISTS `$param_subject1`(
                       id INT(6) UNSIGNED AUTO_INCREMENT PRIMARY KEY,
                       fullname VARCHAR(30) NOT NULL,
                       type1 VARCHAR(30) NOT NULL,
                       email VARCHAR(50),
                       password VARCHAR(50) NOT NULL,
                       attendance VARCHAR(10) NOT NULL
                               )";
                           if ($pdo->query($sql2) === TRUE) {
                               $sql3 = "INSERT INTO `$param_subject1` (fullname, type1, email, password, attendance) VALUES (`$param_teacherName`, 'Teacher', `$param_email`, `$param_password`, 'Present')";
                               $pdo->execute($sql3);
                                   echo "Table MyGuests created successfully";
                               } else {
                                   echo "Error creating table: " . $pdo->error;
                           }


What I have tried:

Please advised me how should I do this. I'm stuck on this problem like weeks and can't find answer on google.
Posted
Updated 24-Apr-21 20:41pm
Comments
Richard Deeming 26-Apr-21 5:46am
   
Creating tables at runtime smells like a really bad database design.

1 solution

Not like that!

There are two big problems here:
1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
2) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^]

And remember: if you have any European Union users then GDPR applies and that means you need to handle passwords as sensitive data and store them in a safe and secure manner. Text is neither of those and the fines can be .... um ... outstanding. In December 2018 a German company received a relatively low fine of €20,000 for just that.
   

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)




CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900