My word. So many things so seriously wrong in so little a code ...
First off, don't create a connection and hold it open. They are a scarce resource, and should be created when needed, opened, used, closed, and disposed when finished with - the same with Command objects and DataReaders. Use a
using
block to ensure that happens automatically.
Your code holds the connection open until the app closes, and creates a new version each time the registration form is cretaed.
Secondly, never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.
When you concatenate strings, you cause problems because SQL receives commands like:
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;
Which SQL sees as three separate commands:
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
DROP TABLE MyTable;
A perfectly valid "delete the table" command
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.
So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
To use concatenation in a registration or login form is just stupid: I don't even have to have a username to destroy your DB!
Next, Never store passwords in clear text - it is a major security risk. There is some information on how to do it here:
Password Storage: How to do it.[
^]
And remember: if you have any European Union users then GDPR applies and that means you need to handle passwords as sensitive data and store them in a safe and secure manner. Text is neither of those and the fines can be .... um ... outstanding. In December 2018 a German company received a relatively low fine of €20,000 for just that.
Then there is the user experience. Why get the user to log in when he just registered? If he didn't know his own password 5 seconds after creating the account what does that prove?
More user experience: If I enter a used username, or my passwords don't match you hide the damn form so I can't edit it and take me to a new login form!
And now, you don't even close or dispose the form: you hide it so it can't be closed by the user either! So the Connection object is permanently open ...