I was executing a problem here is the code of the problem

Question

1.00/5 (2 votes)

See more:

In this code I have applied the code but the problem is that after the 0 the timer should stops and does not print negative values but it is not stopping. Does anybody know better solution to solve to solve this problem as if there is timer of 60 seconds it will print 60,59,58,57,56 and then start skipping and start showing the values 53, 51, 48 upto 0 and then does not print any value..

What I have tried:

JavaScript

var timeleft = 60;
var n=3;
var t=1;
var Timer = setInterval(function(){
    if(timeleft>56){
        timeleft = timeleft - t;
    }
    else{
        timeleft = timeleft - n;
    } 
    console.log(timeleft);
    if(timeleft <= 0)
        clearInterval(Timer);
},1000);

Posted 6-Aug-21 1:14am

Jaskirat Singh 2021

Updated 6-Aug-21 1:34am

Richard Deeming

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2021-08-06T01:34:00

Solution 1

The only negative value printed by your code is -1. That's because you're subtracting three second intervals from 56, which is not divisible by 3.

Once your code hits -1, the timer stops.

If you want to avoid printing -1, change your termination check to:

JavaScript

if (timeLeft < n)
    clearInterval(Timer);

Posted 6-Aug-21 1:34am

Richard Deeming

Comments

[no name] 6-Aug-21 8:01am

at last checkpoint i want to end it at 0 and does not print negative value. But code it is printing the 2 as after the 5 it should end at the 0

[no name] 6-Aug-21 8:08am

if any value entered in n variable it at last checkpoint the timer should stops at 0 and does not print negative values and n can be any value.

Richard Deeming 6-Aug-21 8:43am

You are repeatedly subtracting 3 from 56. 56 is not divisible by 3. Therefore you cannot get to 0. You can either get to 2, or -1.

The only other option is to replace negative values with 0:

if (timeleft > 56){
    timeleft = timeleft - t;
}
else {
    timeleft = timeleft - n;
}

if (timeleft < 0) {
    timeleft = 0;
}

console.log(timeleft);

if(timeleft === 0){
    clearInterval(Timer);
}