What is the mistake in this project

Question

1.00/5 (1 vote)

See more:

i get error under 1st Rep he said Use of unassigned local variable 'Rep' for this code

"while (Rep == 'Y' || Rep == 'y') ;"

What I have tried:

using System;

namespace Loop
{
    class Program
    {
        static void Main(string[] args)
        {

            int Num = 4;
            char Rep;
           do
            {
                Console.WriteLine("Guess The No.");
                int GNum = int.Parse(Console.ReadLine());
                if (GNum == Num) Console.WriteLine("Great You Win");
                else
                {
                    Console.WriteLine("Good Luck second time");
                    Console.WriteLine("Do you want to try again ? Y or N");
                    Rep = char.Parse(Console.ReadLine());
                }
           } while (Rep == 'Y' || Rep == 'y') ;
           
        }
    }
}

Posted 11-Sep-21 19:41pm

Abou Hashem

Updated 11-Sep-21 21:59pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2021-09-11T19:49:00

You get the error because there is a path through the code where the first use of the variable can occur without a value being assigned to it: if the if test passes then no value is ever assigned.

The simplest solution is to assign a value when you create the variable:

C#

char Rep = 'n';

But you should stick to naming conventions: local variables should be named in "camelCase" so they start with a lowercase letter:

C#

int num = 4;
int rep = 'n';

Classes, Enums, Properties, and Methods start with uppercase letters but not "local variables"

Patrice T · Answer 2 · 2021-09-11T21:59:00

You can try this way too:

C++

using System;

namespace Loop
{
    class Program
    {
        static void Main(string[] args)
        {

            int Num = 4;
            char Rep;
           do
            {
                Console.WriteLine("Guess The No.");
                int GNum = int.Parse(Console.ReadLine());
                if (GNum == Num)
                    Console.WriteLine("Great You Win");
                else
                {
                    Console.WriteLine("Good Luck second time");
                }
                Console.WriteLine("Do you want to try again ? Y or N");
                Rep = char.Parse(Console.ReadLine());
           } while (Rep == 'Y' || Rep == 'y') ;
           
        }
    }
}

or:

C++

using System;

namespace Loop
{
    class Program
    {
        static void Main(string[] args)
        {

            int Num = 4;
            char Rep;
           do
            {
                Console.WriteLine("Guess The No.");
                int GNum = int.Parse(Console.ReadLine());
                if (GNum == Num) {
                    Console.WriteLine("Great You Win");
                    break;
                }
                else
                {
                    Console.WriteLine("Good Luck second time");
                    Console.WriteLine("Do you want to try again ? Y or N");
                    Rep = char.Parse(Console.ReadLine());
                }
           } while (Rep == 'Y' || Rep == 'y') ;
           
        }
    }
}

Advice: Do not try to save a keystroke by packing lines.
On long term, it makes your code more diffcult to read and understand. See the change I made for the 'you win'.

What is the mistake in this project

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0