Group wise sum incorrect in SQL

Question

0.00/5 (No votes)

See more:

SQL

SELECT {fn MONTHNAME(feepaiddate)} AS MonthName,YEAR(feepaiddate) AS Year, SUM(paidAmt) AS Profits FROM [bitcrj_database].[tbstufees]
 GROUP BY { fn MONTHNAME(feepaiddate) }, MONTH(feepaiddate), YEAR(feepaiddate)  order by Year(feepaiddate),month(feepaiddate)

Output:-

Month | Year | Profits
------ | ---------| ---------
January | 2022 | 34800
February | 2022 | 40500
March | 2022 | 43600 // Incorrect Sum in march

but i manual count in March month SUM is Correct 42000

What I have tried:

i want to correct output of month march

Posted 24-Mar-22 23:47pm

Nishant.Chauhan80

Updated 25-Mar-22 3:45am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2022-03-25T00:08:00

Check your inputs: the chances are they aren't what you think.

And don't GROUP BY the same data twice: month name and number. Instead, write a GROUP by that returns the year, month, and sum - then test that in isolation. When that works, JOIN that back to the original table to pick up the month name and ORDER BY

CHill60 · Answer 2 · 2022-03-25T03:45:00

I do agree with OriginalGriff's statement

Quote:
Check your inputs: the chances are they aren't what you think.

because I set up some dummy data and your code works fine.

I tend to disagree with him on the join to the original table though - what are you going to join to? You can however, join to a sub-query or CTE that does this

SQL

select distinct DATENAME(MONTH, feepaiddate) AS [MonthName], MONTH(feepaiddate) as [MonthNo]
	FROM tbstufees

(inner join on [MonthNo]

One other point, why are you using ODBC scalar functions just to get the month name? Why not use the built-in SQL functions? e.g.

SQL

{fn MONTHNAME(feepaiddate)} AS MonthName

can be replaced with

SQL

DATENAME(MONTH, feepaiddate) AS [MonthName]

Your query will run faster.

Also note that I am surrounding the reserved words MonthName and Month with square brackets when they are used as column aliases - this is to signal that they are definitely column names and not the functions with the same name. Or note that I used MonthNo instead of Month avoiding the problem altogether

Group wise sum incorrect in SQL

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0