Why my data "staff_score" did not show the error message when it is false?

Question

0.00/5 (No votes)

See more:

The staff score is an array value. The form still submitted even the text field is not filled or 0.

What I have tried:

$data['staff_score'] = array();

switch ($_POST['mode']) {		
				
		case 'submit':
			
			$ValidProcess = true;
	
			//this method is for 'staff_score'//NOT VALID
			if (count($_POST['staff_score'])> 0){
				$data ['staff_score'] = $_POST['staff_score'];
			}
			
			$isValid = false;
			foreach ($data['staff_score'] as $key => $value){
				if ($value > 0){
					$isValid = true;
					break;
				}
			}
			if (!$isValid){
				$ValidProcess = false;
				$errorMsg[]= 'Please Insert Your Score.';
			}
			
					
			//database
			if($ValidProcess) {
				$ValidProcess = true;
				
			} 
     break;
}

Posted 5-Jun-22 17:48pm

Zatil Syamimi

Updated 6-Jun-22 0:03am

v2

Add a Solution

Comments

Member 15627495 6-Jun-22 18:16pm

hello Zatil Syammi !

error handling is hard times.

Choose the 'golden path' :
- write the code needed when your input is compliant and perfect.
and as you know failure case ( score = 0 , or not fill ) , add 2 or three line for handling those errors.

It's like 'testing' your code, but the benchmark is made firstly with perfect datas for the needs.

at the step after , add few errors in the input array. then add handling errors lines.

It's like dividing a functions by two smaller functions,
send firstly a compliant array , add all the score within a loop. return the score sum.

then introduce error in a new array, and handles the error the ways needed.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2022-06-06T00:03:00

I suspect you are checking the wrong way. In your check of the scores array, if any one value is greater than zero you set valid to True, and do not check the remaining entries. A better method would probably be:

PHP

$isValid = true;
foreach ($data['staff_score'] as $key => $value){
    if ($value == 0){
        $isValid = false; // no further checks needed if any value is zero
        break;
    }
}

You also have a redundant piece of code at:

PHP

if($ValidProcess) {
    $ValidProcess = true; // if it is already true then this line is not needed

}