Codeigniter4 helper function not working according to requirements

Question

0.00/5 (No votes)

See more:

Hello,

I have a helper function which has to check for permission if granted then return true and the controller function executes, and if the permission not granted then redirect to dashboard.

But here if the permission not granted its, it displays the message that permission not granted and the goes forward and execute next line instead of going to dashboard.

I hope you understand my problem and will help.

thanks in advance.

What I have tried:

PHP

<pre>//Helper Function

if(!function_exists('chkPermissions')){
    function chkPermissions($action){
        $roleid = session()->get('roleid');
        $router = service('router'); 
	   $controller  = class_basename($router->controllerName());  // Controller / Class Name
        $model = new ModelPermissions();
        $data = $model->where(['roleid' => $roleid,'controller' => $controller, $action => '1'])->first();
        if($data == null) {
		// if permission not grantted then goto dashboard
        session()->setFlashdata('error', 'Permission not grantted, try again!');
        return view('dashboard/index',false);        
            }  

// if permission granted return true			
         return true;
    }
}




//Controller's Function

public function index()
    {
		chkPermissions('view');
// if permission were not granted, should not execute the below line		
        return view('home/index');
       
    }

Posted 22-Jun-23 21:22pm

nyt1972

Updated 23-Jun-23 0:37am

Add a Solution

2 solutions

Solution 2

You should fall into the habit of doing error checking whilst coding, this will save you a tremendous amount of time on debugging -

try {
    // Code that may throw an exception
} catch (Exception $e) {
    // Handle the exception
    log_message('error', $e->getMessage()); // Log the error message
    show_error('An error occurred. Please try again later.'); // Display a user-friendly error message
}

CHris's code and explanation is spot on, if you still want to re-direct to your dashboard page, just add -

if ($data == null) {
            // if permission not granted then go to dashboard
            session()->setFlashdata('error', 'Permission not granted, try again!');
            return redirect()->to('dashboard/index');
        }

Posted 23-Jun-23 0:37am

Andre Oosthuizen

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Chris Copeland · Accepted Answer · 2023-06-23T00:06:00

It's probably because you're not actually doing anything with the return value of the function you've created. The function returns either a boolean or the result of a function call to view('dashboard/index', false);, but you don't do anything with either result.

Instead you could make the function return true or false and then do something different in each instance?

if (!function_exists('chkPermissions')) {
  function chkPermissions($action) {
    $roleid = session()->get('roleid');
    $router = service('router'); 
	$controller  = class_basename($router->controllerName());  // Controller / Class Name
    $model = new ModelPermissions();
    $data = $model->where([
      'roleid' => $roleid,
      'controller' => $controller, $action => '1'])->first();
    
    if ($data == null) {
      // if permission not grantted then goto dashboard
      session()->setFlashdata('error', 'Permission not grantted, try again!');

      // Changed this here to return false when no permission set
      return false;       
    }  

    // if permission granted return true			
    return true;
  }
}




//Controller's Function

public function index()
{
  // See here we check the return value (true or false) of the function
  // call and if false then we navigate
  if (!chkPermissions('view'))
    return view('dashboard/index', false);

  return view('home/index');       
}