Click here to Skip to main content
15,877,754 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
I have five check boxes in a form and I have list of string. I want to check all check boxes if their text is found in this list of strings, then set check state to true.
Notice: mylist is { Clients, Sales, Items } and panel1 has only five Checkboxes and these Checkboxes text is Clients, Sales, Items, Buys, Debts.

The below code is working fine but sets only first check box state to true.

What I have tried:

Private Sub Button2_Click(sender As System.Object, _
e As System.EventArgs) Handles Button2.Click

        Dim mylist As List(Of String) = My.Settings.CountTitle.Split(",").ToList
        For i As Integer = 0 To mylist.Count - 1
            For Each box As CheckBox In Panel1.Controls
                If box.Text = mylist(i) Then
                    box.Checked = True
                End If
    End Sub
Updated 12-Oct-23 9:44am

1 solution

We can't help you - we have no access to your data, and it is very much crucial to how that code runs.

So, it's going to be up to you.
Fortunately, you have a tool available to you which will help you find out what is going on: the debugger. If you don't know how to use it then a quick Google for "Visual Studio debugger" should give you the info you need.

Put a breakpoint on the first line in the function, and run your code through the debugger. Then look at your code, and at your data and work out what should happen manually. Then single step each line checking that what you expected to happen is exactly what did. When it isn't, that's when you have a problem, and you can back-track (or run it again and look more closely) to find out why.

Sorry, but we can't do that for you - time for you to learn a new (and very, very useful) skill: debugging!

Is there an error in my question?
Not as such, it's just that the problem isn't solvable without the actual data it's working with - and we don't have access to that but you do. So we don't know what mylist contains, or what it's Count property might evaluate to, or that Panel1 has any Controls, or that they are all CheckBoxes, or what their Text might be. And we have no way to find out - but you do!

Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send. Compiling does not mean your code is right! :laugh:

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
Private Function Double(ByVal value As Integer) As Integer
    Return value * value
End Function

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to while it's running).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Sorry! My question updated

And? What does the debugger show you is happening when you run your code? You seem to be making assumptions rather than watching what your code is actually doing with your actual data. Remember that even a leading or trailing space, or a change of case can make what looks like identical strings not match:
"string"  == "string"
"string " != "string"
" string" != "string"
"String"  != "string"
That's why it's essential to use your actual data, your actual controls rather than assuming anything.

For example, if your input string CountTitle looked like this:
Clients, Sales, Items
Then your Split would give you three strings: "Clients", " Sales", and "" Items" - and only the first would probably match your control.Text property.

Assumptions are killers when you debug - because what you assume is right doesn't have to be and that throws you right off on a "but why doesn't it work?" branch instead of a "why doesn't that data look right?" one.
Share this answer
Member 13356291 11-Oct-23 18:06pm    
Is there an error in my question?
OriginalGriff 12-Oct-23 1:30am    
Solution updated.
Member 13356291 12-Oct-23 9:49am    
Sorry! My question updated
OriginalGriff 12-Oct-23 10:30am    
Solution updated.
Member 13356291 12-Oct-23 11:07am    
thanks! my problem is solved as you said

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900