Cedit control - access violation error

Question

0.00/5 (No votes)

See more:

Hello! Need some help - I have MS VC++ 6 project; so I'm just trying to add EDIT control to the one of my modal window (IDC_EDIT1), variable m_Edit1 (CEdit) and even after that this is impossible to open such window. Application crashed with "Access violation" error - NTDLL.DLL (0xC0000005). If i remove this variable via Class Wizard - all is OK again. And I found this problem in every window - even in the main form. What does it mean? Thank you for support.

What I have tried:

header file:

// Dialog Data
	//{{AFX_DATA(CNotebooksDlg)
	enum { IDD = IDD_NOTEBOOKS_DIALOG };
	CEdit	m_Edit1;
	CComboBox	m_ComboSerial;
	CComboBox	m_ComboDeviceType;
	CSortListCtrl	m_ctrlListHistory;

cpp file:

//{{AFX_DATA_MAP(CNotebooksDlg)
DDX_Control(pDX, IDC_EDIT1, m_Edit1);
DDX_Control(pDX, IDC_COMBO_SERIAL_NUMBER, m_ComboSerial);
DDX_Control(pDX, IDC_COMBO_DEVICE_TYPE, m_ComboDeviceType);
DDX_Control(pDX, IDC_LIST_HISTORY, m_ctrlListHistory);

Posted 9-Feb-24 2:27am

shupike

Updated 9-Feb-24 2:28am

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

k5054 · Answer 1 · 2024-02-09T02:49:00

Solution 1

You need to call m_Edit.create( style, rect, parent, ID) before you can use the CEdit object.

Posted 9-Feb-24 2:49am

k5054

Comments

shupike 9-Feb-24 9:48am

You know - I just added all necessary strings manually and it works! I mean - without Class Wizard using. Looks like some problem in Visual Studio - how do you think?

Rick York 9-Feb-24 11:11am

The question was far from clear but if the controls for the dialog(s) are in the resource file then one does not need to create them. The DDX_CONTROL statement will map the object to the resource so calling create is unnecessary.

Rick York · Answer 2 · 2024-02-09T05:28:00

There are three steps to making a control in a dialog work with an MFC program. You did two of them and omitting the third will result in the behavior you observed. The third step is to add an edit control to your IDD_NOTEBOOKS_DIALOG with the identifier IDC_EDIT1 in the resource file. This is usually done with the resource editor but it can be done manually if you prefer.

FWIW, I have worked with MFC a long, long time and eventually I got in the habit of never putting dialog class declarations in header files because it is just unnecessary. With the proper interface, nothing else needs to know the details of a dialog's implementation except the dialog itself. The key to this is the interface. A typical interface I would write would like something like this :

C++

bool OpenNotebookDlg( CWnd * pparent, NotebookData & data );

The implementation of that function would be with the dialog's code and would initialize the controls with the data and then, if OK is clicked it extracts the data from the dialog and returns true. Usually I would have an Edit method in the NotebookData class and its implementation would call the function shown. I have found this to be a very clean and easy to use practice. The one caveat to it is the dialog code has to know about the data it is displaying but I consider that to be a fair and appropriate trade-off.