How to get 2 images from SQL DB

Question

0.00/5 (No votes)

See more:

Dear Sirs
I am self learning to C# I am doing a project for Assets management
I create user control showing two images (QRCode with BarCode) all ok ad these 2 images saved to sql DB by byte.but when I want to display them in the usercontrol only shows two copy of the image(QRcode) I know there is something wrong can I get help please and how to print the result my code :

What I have tried:

C#

public void LoadQRBRCode()
        {
            string qry = "Select * from tblQrBar  ";
            SqlCommand cmd = new SqlCommand(qry, MainClass.con);
            SqlDataAdapter da = new SqlDataAdapter(cmd);
            DataTable dt = new DataTable();
            da.Fill(dt);

            foreach (DataRow item in dt.Rows)
            {
                Byte[] imagearray = (byte[])item["QrImage"];
                byte[] immagebytearray = imagearray;


                Byte[] imagearray1 = (byte[])item["barImage"];
                byte[] immagebytearray1 = imagearray1;

                AddItems("0", item["IDCode"].ToString(), Image.FromStream(new MemoryStream(imagearray)),
                    Image.FromStream(new MemoryStream(imagearray1)));
            }

Posted 22-Apr-24 10:27am

sami alhassan

Updated 22-Apr-24 11:27am

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 22-Apr-24 17:29pm

What does AddItems do?
Should the "0" be a different value on each call?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2024-04-22T19:08:00

There are a few problems here. With your existing code, you need to re-think it as the documentation[^] is very clear:

Remarks:

You must keep the stream open for the lifetime of the Image.

Since your stream is created and no reference to it is preserved once the method ends, it is liable for Disposal at any time the GC decides.

It's also considered a bad idea to use SELECT * FROM tblQrBar as it pulls all columns - you should specify only the data you are actually interested in to save bandwidth: SELECT QrImage, BarImage FROM tblQrBar

You also don't limit the number of rows you pull in, so if AddItem adds data to a control of some form then you are going to get a very slow and resource hungry app pretty quickly as codes are added to your system: Page them, sort them, search them, filter them - don't just dump them on the user and let him sort it out!

The problem you have noticed is likely to be outside that code: check your code to insert images to your DB - best guess is you INSERT the same image twice when you load your DB.