How dowhy I am still getting this warning while I am using set accessor ? I...

Question

1.00/5 (1 vote)

See more:

hello i have this class but iam still having the below warring in visual studio while i am using set accssor to set the name feild

Quote:
Severity Code Description Project File Line Suppression State Warning (active) CS8618 Non-nullable field '_name' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. C#ForBeginners D:\Projects\C#ForBeginners\C#ForBeginners\Program.cs 15 `

public class Student
{
    private int _id;

    private string _name;

    private int _PassMark = 35;


    public int ID
    {
        set
        {
            if (value < 0)
            {
                throw new Exception("id feild can be negative value");
            }

            _id = value;
        }
        get
        {
            return _id;
        }
    }

    public string Name
    {
        set
        {
            if (string.IsNullOrEmpty(value))
            {
                _name = "No Name";

            }

            _name = value;
        }
        get
        {
            return _name;
        }
    }

}

What I have tried:

what i have tried is that i added the `?` beside the field to make the compiler understand that the feild accepts null values;

Posted 26-May-24 16:33pm

Member 14479161

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Answer 1 · 2024-05-26T18:18:00

It's telling you that _name needs to have a value assigned to it by the time the Student class constructor is finished executing.

All you have to do is change

C#

private string _name;

to assign an Empty string to it or some other appropriate default value.

C#

private string _name = string.Empty;

OriginalGriff · Answer 2 · 2024-05-26T18:57:00

To add to what Dave has said, you should expect to get syntax errors every day, probably many times a day while you are coding - we all do regardless of how much experience we have! Sometimes, we misspell a variable, or a keyword; sometimes we forget to close a string or a code block. Sometimes the cat walks over your keyboard and types something really weird. Sometimes we just forget how many parameters a method call needs.

We all make mistakes.

And because we all do it, we all have to fix syntax errors - and it's a lot quicker to learn how and fix them yourself than to wait for someone else to fix them for you! So invest a little time in learning how to read error messages, and how to interpret your code as written in the light of what the compiler is telling you is wrong - it really is trying to be helpful!

So read this: How to Write Code to Solve a Problem, A Beginner's Guide Part 2: Syntax Errors[^] - it should help you next time you get a compilation error!

And spending a little time learning to understand syntax error messages will save you a huge amount of time in future: you waited nearly 2 hours for Dave to reply, then your email system probably added another 10 minutes or so, plus the time it took you to type up the question once you had found this site and created an account. Chances are that you could have saved a significant chunk of that time if you knew how to read them!

I'm not saying we don't want to help you fix them - sometimes I can't see my own errors because I read what I meant to write - but fixing syntax errors is part of the job, and if you can't do it for yourself people are going to look at you as a bit weird should you get a job in the industry!

George Swan · Answer 3 · 2024-05-27T03:20:00

A simple solution to your problem is to assign the default value of _name in your class definition; private string _name="No Name". My preference would be to limit the class definition to assignments only. In your definition you are both testing the input and then assigning it. In strict terms, that runs contrary to the single responsibility principle.

How dowhy I am still getting this warning while I am using set accessor ? I...

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0