Linked List with Multiple Data Items

Question

3.50/5 (2 votes)

See more:

I'm trying to create a linked list which contains more than just a single piece of data. The program will run and allow me to enter as many structs as I want but when I quit it, it will correctly print out the last structure entered, twice, and then crash.

I assume I'm doing something not right with the pointers.

Here's the code:

void main(void)
{
	int x;
	struct Student
	{
		int id;
		string name;
		string courseCode;
		struct Student *next; 
	} *start, *p;

	Student student;
	start = NULL; 
	
	printf("Enter a sequence of integers, letter to end: ");
	while(cin>>x)
	{
		p = &student;
		start = (Student *)malloc(sizeof(struct Student));
		if(start == NULL)
		{
			cout<<"Not enough memory";
			exit(1);
		}
		cout<<"Enter Student ID: ";
		cin>>student.id;
		cin.sync();
		cout<<endl<<"Enter Student Name: ";
		getline(cin, student.name);
		cin.sync();
		cout<<endl<<"Enter Course Code: ";
		getline(cin, student.courseCode);
		cin.sync();
		
		student.next = p;

	}

	cout<<endl<<"In reverse order, the following details were entered: "<<endl;
	

	for(p = start; p != NULL; p = p->next)
	{
		cout<<student.id<<endl;
		cout<<student.name<<endl;
		cout<<student.courseCode<<endl;
	}
}

Posted 16-Feb-13 8:21am

BrianHamilton

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Fredrik Bornander · Accepted Answer · 2013-02-16T09:18:00

In the last loop you're printing the data for student instead of for p.
student doesn't change in the loop, it's p that changes so you should be printing that instead.

Also, in C++ you really don't want to call malloc when you have new, these links will point you in the right direction;

http://msdn.microsoft.com/en-us/library/kewsb8ba(v=vs.71).aspx[^]
http://stackoverflow.com/questions/655065/when-should-i-use-the-new-keyword-in-c[^]

This slightly changed implementation kind-of does what you want I think;

C++

#include<iostream>
#include<string>

using namespace std;

struct Student
{
    int id;
    string name;
    string courseCode;
    struct Student* next;
};


void main(void)
{
    int x;

    Student* previous = NULL;
    Student* start = NULL;

    printf("Enter a sequence of integers, letter to end: ");
    while(cin>>x)
    {
        Student* student = new Student;
        student->next = NULL;

        if (start == NULL)
            start = student;

        cout<<"Enter Student ID: ";
        cin>>student->id;
        cin.sync();
        cout<<endl<<"Enter Student Name: ";
        getline(cin, student->name);
        cin.sync();
        cout<<endl<<"Enter Course Code: ";
        getline(cin, student->courseCode);
        cin.sync();

        if (previous != NULL)
            previous->next = student;

        previous = student;
    }

    cout<<endl<<"In reverse order, the following details were entered: "<<endl;


    for(Student* p = start; p != NULL; p = p->next)
    {
        cout<<p->id<<endl;
        cout<<p->name<<endl;
        cout<<p->courseCode<<endl;
    }
}

Hope this helps,
Fredrik