Trying to convert string to upper class

Question

5.00/5 (1 vote)

See more:

C#

// String_Processingg.cpp : Defines the entry point for the console application.
//

#include "stdafx.h"
#include<iostream>
using namespace std;
#include<stdio.h>
#include<ctype.h>
#include<string>
#include <cstdlib>

void upper(string t  );

int _tmain(int argc, _TCHAR* argv[])
{

    char s[100];

    while(gets(s))
    {
        upper(s);
        puts(s);

    }
    return 0;
}

void upper(string t)
{

    while(*t)
        *t=toupper(*t);
    t++;
}

Errot:No operator ++ and *matches these operand.

Please help remove these error.
thanks in advance

Posted 17-Feb-13 20:16pm

vikrant vaibhav

Add a Solution

2 solutions

Solution 2

What you have here is rather a C program: all the functions you use are C library functions, not C++ functions.
The whole program is rather carelessly written:
- Don't have "using" between includes.
- Don't mix c-style includes with C++ style C library includes (the C++ style C library includes wrap the C code into namespace std). Choose one style an stick on it.
- Since you decided to use C functions, use the appropriate types (e.g. char buffer instead of string - in that case you have to decide on the string buffer size and use the respective safe gets function - or you may completely avoid a buffer and run the program character wise: getchar/putchar).
- Classical trap of omitting curly braces in a while block: the upper function's while block is brocken due to that: t++ need to be part of the loop.

Is this a code fragmet that you got to correct or is this your own code? It looks rather broken.
Sorry for not giving more clear advise. It looks like homework assignment, and you have to do it yourself to learn something.

Cheers
Andi

Posted 17-Feb-13 20:37pm

Andreas Gieriet

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

merano · Accepted Answer · 2013-02-17T20:27:00

Solution 1

C#

void upper(char *t );

Posted 17-Feb-13 20:27pm

merano

Comments

vikrant vaibhav 18-Feb-13 2:30am

thanks ..