a select query one is giving result and another same is not what the hell it is

Question

0.00/5 (No votes)

See more:

cmd.CommandText = "select fname,mbn,kskill,resume,email from reg where cl="+ddlocation.SelectedItem+"";
this query is not giving result

XML

if (ds.Tables[0].Rows.Count > 0)
           {
               GridView1.DataSource = ds.Tables[0];
               GridView1.DataBind();
           }
           else
           {
               Response.Write("<script> alert('no match found') </script>");
          }

the control is going to else everytime, and another cmd.CommandText = "select fname,mbn,kskill,resume,email from reg where jobtype='" + Ddjobtype.SelectedItem + "'"; query giving a correct result.
i did not understand what the problem is this database is correct no mistake with any field or any column

Posted 17-Mar-13 2:06am

Member 9841216

Add a Solution

Comments

[no name] 17-Mar-13 8:27am

is "cl" an int? Did you try and run your queries outside of your code? Did they return results then? In your first query, what is the purpose of adding an empty string at the end of the query? Did you try using a parameterized query instead of this SQL injection attack waiting to happen?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-03-17T02:29:00

The chances are that it's to do with the content of the drop down list: when you put quotes around it as in your second example, it works because SQL knows to expect it as a string.

However, it would be a much, much better idea to use a Parametrized query instead:

C#

cmd.CommandText = "SELECT fname,mbn,kskill,resume,email FROM reg WHERE cl=@CL";
cm.Parameters.AddWithValue("@CL", ddlocation.SelectedItem);

This would also help to protect you from accidental or deliberate SQL Injection attacks.