Can i give || instead of using 'OR'? I am getting Error1 :Invalid expression term '||'

Question

1.00/5 (1 vote)

See more:

C#

protected void Cmdupload_Click(object sender, EventArgs e)
        {
            if (FileUpload1.HasFile)
            {
                string filext = System.IO.Path.GetExtension(FileUpload1.FileName);
              // Here Problem! if (filext == ".png") || (filext == ".jpeg")
                {
                    try
                    {
                        _Imgname = Path.GetFileName(FileUpload1.PostedFile.FileName);
                        FileUpload1.SaveAs(Server.MapPath("Prdo_Images/" + _Imgname));
                        _ImgPath = "Prdo_Images/" + FileUpload1.FileName;
                        ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('File Uploaded Succesfully');", true);
                    }
                    catch (Exception ex)
                    {
                         ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('Error ')" + ex.Message + ";", true);
                    }
                }
                else
                {
                    ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('Only png or Jpeg files allowed!');", true);

                }
            }
            else
            {
                ClientScript.RegisterStartupScript(this.GetType(), "myalert", "alert('You have not specified file.');", true);
            }

        }

Please help!!

Thanks in advance

Posted 10-Jul-13 12:57pm

Sugu Thomas

Updated 10-Jul-13 13:07pm

v4

Add a Solution

2 solutions

Solution 1

Instead of

Quote:
if (filext == ".png") || (filext == ".jpeg")

try

if (filext == ".png" || filext == ".jpeg")

Posted 10-Jul-13 13:12pm

CHill60

Comments

Sergey Alexandrovich Kryukov 10-Jul-13 19:34pm

That's correct, but, if you look at my answer, you will see that it still does not resolve the practical problem. Different casing should be taken into account...
—SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-07-10T13:15:00

There is no "OR" operator. Should be:

C#

if ((filext == ".png") || (filext == ".jpeg"))
    // ...

Can you spot the difference? :-)

Besides, this check is no good, because it misses the possibility of correct names with "*.PnG", "*.JPG", "*.JPg" and so on. You don't really need to use it, as you can use the file dialog filter. But if you think you really need to checkup "extension", it could be something like:

C#

loExt = fileExt.ToLower();
if ((loExt == ".png") || (loExt == ".jpeg") || (loExt == ".jpg"))
   //...

Please see: http://msdn.microsoft.com/en-us/library/system.string.tolower.aspx[^].

And finally, even though you need to use '||' in almost all cases, you should clearly understand the difference between '|' and '||' operators:
http://msdn.microsoft.com/en-us/library/kxszd0kx.aspx[^],
http://msdn.microsoft.com/en-us/library/6373h346.aspx[^].

—SA